style.css should be split

We should have several meaningful css instead of one big one.

Also it would be good if could find a way of auto-loading them from a folder, allowing themes to easily provide css that adds up to the existing ones. (instead of having to copy paste the existing one)

(from redmine: issue id 2409, created on 2013-05-14, closed on 2013-07-09)

• Relations:
  • relates #2436
• Changesets:
  • Revision c311a695 by Côme Chilliet on 2013-05-17T20:27:03.000Z:

Fixes: #2409 Improving theme handling

• Revision 275eef2a by Côme Chilliet on 2013-05-17T20:28:39.000Z:

Fixes: #2409 style.css should be split

• Revision a318308e by Côme Chilliet on 2013-05-22T11:54:56.000Z:

Fixes: #2409 logout.php should not create smarty

• Revision 3ac30572 by Côme Chilliet on 2013-05-22T12:03:24.000Z:

Fixes: #2409 Some responsive design

• Revision 2206fa67 by Côme Chilliet on 2013-05-22T12:03:41.000Z:

Fixes: #2409 Adapted simple-plugin look to smartphones

• Revision c1c346f8 by Côme Chilliet on 2013-05-22T12:03:58.000Z:

Fixes: #2409 few CSS fixes

• Revision b587755d by Côme Chilliet on 2013-05-22T15:10:25.000Z:

Fixes: #2409 fixes a wheezy problem with filePath

• Revision fbdf5af4 by Côme Chilliet on 2013-05-23T08:11:37.000Z:

Fixes: #2409 Fixed logo path in login.tpl

• Revision 79c41585 by Côme Chilliet on 2013-05-23T20:06:07.000Z:

Fixes: #2409 Adapting form inputs on small screens

• Revision 6d7ae0cc by Côme Chilliet on 2013-05-24T10:40:13.000Z:

Fixes: #2409 Adapted user list to small screens

• Revision 3c9713eb by Côme Chilliet on 2013-05-24T14:45:54.000Z:

Fixes: #2409 Improving theme handling

• Revision a308d048 by Côme Chilliet on 2013-05-24T14:46:19.000Z:

Fixes: #2409 style.css should be split

• Revision 4dc9a7a4 by Côme Chilliet on 2013-05-24T14:46:46.000Z:

Fixes: #2409 logout.php should not create smarty

• Revision b0d4911f by Côme Chilliet on 2013-05-24T14:54:23.000Z:

Fixes: #2409 Some responsive design

• Revision 652873fe by Côme Chilliet on 2013-05-24T14:54:49.000Z:

Fixes: #2409 Adapted simple-plugin look to smartphones

• Revision 9052394e by Côme Chilliet on 2013-05-24T14:55:11.000Z:

Fixes: #2409 few CSS fixes

• Revision 22aaa611 by Côme Chilliet on 2013-05-24T14:55:37.000Z:

Fixes: #2409 fixes a wheezy problem with filePath

• Revision 4e209d29 by Côme Chilliet on 2013-05-24T14:56:00.000Z:

Fixes: #2409 Fixed logo path in login.tpl

• Revision 42f07675 by Côme Chilliet on 2013-05-24T14:56:31.000Z:

Fixes: #2409 Adapting form inputs on small screens

• Revision fe2a6620 by Côme Chilliet on 2013-05-24T14:56:58.000Z:

Fixes: #2409 Adapted user list to small screens

• Revision 39639e70 by Côme Chilliet on 2013-05-27T16:26:15.000Z:

Fixes: #2409 Improved list styling

• Revision 01031e23 by Côme Chilliet on 2013-05-27T17:26:46.000Z:

Fixes: #2409 Improved list styling

• Revision 7b33c797 by Côme Chilliet on 2013-06-06T12:25:34.000Z:

Fixes: #2409 Improved list handling

• Revision 7ec4cd5c by Côme Chilliet on 2013-06-06T12:25:56.000Z:

Fixes: #2409 Improved list handling

• Revision 8e547fbf by Côme Chilliet on 2013-06-20T10:08:09.000Z:

Fixes: #2409 Some mobile table css improve

• Revision 476a3477 by Côme Chilliet on 2013-06-20T10:08:23.000Z:

Fixes: #2409 Some mobile table css improve

• Custom Fields:
  • Bug in version: 1.0.5
• Uploads:
  • 0001-Fixes-2409-Improving-theme-handling.patch
  • 0002-Fixes-2409-style.css-should-be-split.patch
  • 0003-Fixes-2409-logout.php-should-not-create-smarty.patch
  • 0004-Adapted-login-to-new-css-organization.patch
  • 0005-Fixes-2409-Some-responsive-design.patch
  • 
  • 0006-Fixes-2409-Adapted-simple-plugin-look-to-smartphones.patch
  • 0007-Fixes-2409-few-CSS-fixes.patch
  • 0008-Fixes-2409-fixes-a-wheezy-problem-with-filePath.patch
  • 0009-Fixes-2409-Fixed-logo-path-in-login.tpl.patch
  • 00010-Fixes-2409-Adapting-form-inputs-on-small-screens.patch
  • 00011-Improved-plugbottom-button-display-on-phones.patch
  • 00012-Fixes-2409-Adapted-user-list-to-small-screens.patch
  • 00013-Fixes-2409-Improved-list-styling.patch
  • 00014-Fixes-2409-Improved-list-handling.patch
  • 00015-Fixes-2409-Some-mobile-table-css-improve.patch

With this patch theme creating is much more handy : you don't have to copy every files anymore, you can do a theme containing only a logo image or a style.css file. I added a smarty plugin function filePath that takes care of searching a file in the current theme.

Now I need to use it everywhere there are path in tpls to ease theme creation.

We still need to split style.css through.

(from redmine: written on 2013-05-17)

By Côme Chilliet on 2017-09-02T14:59:57 (imported from GitLab)

style.css is now split in small files. css.tpl is used to include all css files.

theme.css is empty and can be override by themes which want to add some css.

(from redmine: written on 2013-05-17)

By Côme Chilliet on 2017-09-02T14:59:57 (imported from GitLab)

There is a fatal error in logout.php when auto logout is triggered. It says it can't find css.tpl. (I suppose this is because there is no theme in the session anymore)

(from redmine: written on 2013-05-21)

By Côme Chilliet on 2017-09-02T14:59:57 (imported from GitLab)

This fixes the problem: for some reason logout.php was creating a new smarty instead of using the one defined in php_setup.inc.

(from redmine: written on 2013-05-21)

By Côme Chilliet on 2017-09-02T14:59:58 (imported from GitLab)

Adapted login a bit. The expired account screen would need some work too

(from redmine: written on 2013-05-21)

By Côme Chilliet on 2017-09-02T14:59:58 (imported from GitLab)

Hello,

when testing the latest build, i got this error at login page

Fatal error: Uncaught exception 'SmartyCompilerException' with message 'Syntax Error in template "/usr/share/fusiondirectory/ihtml/themes/default/headers.tpl" on line 20 "{include file={filePath file="css.tpl"}}" unknown tag "filePath"' in /usr/share/php/smarty3/sysplugins/smarty_internal_templatecompilerbase.php:656 Stack trace: #0 /usr/share/php/smarty3/sysplugins/smarty_internal_templatecompilerbase.php(441): Smarty_Internal_TemplateCompilerBase->trigger_template_error('unknown tag "fi...', 20) #1 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(2392): Smarty_Internal_TemplateCompilerBase->compileTag('filePath', Array) #2 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(3095): Smarty_Internal_Templateparser->yy_r36() #3 /usr/share/php/smarty3/sysplugins/smarty_internal_templateparser.php(3195): Smarty_Internal_Templateparser->yy_reduce(36) #4 /usr/share/php/smarty3/sysplugins/smarty_internal_smartytemplatecompiler.php(105): Smarty_ in /usr/share/php/smarty3/sysplugins/smarty_internal_templatecompilerbase.php on line 656

Cheers

(from redmine: written on 2013-05-22)

By bmortier on 2017-09-02T14:59:58 (imported from GitLab)

There was a wrong path in login.tpl, FD logo was not displayed anymore.

(from redmine: written on 2013-05-23)

By Côme Chilliet on 2017-09-02T14:59:58 (imported from GitLab)

The user list is now easier to use on small screens. I also deleted useless things, and replaced a useless table by a div in framework.tpl

(from redmine: written on 2013-05-24)

By Côme Chilliet on 2017-09-02T14:59:59 (imported from GitLab)

There are problem with the password recovery pages, logos are gone and they does not fit well on small screens

(from redmine: written on 2013-05-27)

By Côme Chilliet on 2017-09-02T14:59:59 (imported from GitLab)

Previously mentioned problems are fixed in #2435

(from redmine: written on 2013-05-27)

By Côme Chilliet on 2017-09-02T14:59:59 (imported from GitLab)

All lists are now correctly displayed on small screens

(from redmine: written on 2013-06-06)

By Côme Chilliet on 2017-09-02T15:00:00 (imported from GitLab)

Close issue

(from redmine: written on 2013-07-03)

By Côme Chilliet on 2017-09-02T15:00:00 (imported from GitLab)

closed

By Côme Chilliet on 2017-09-02T15:00:00 (imported from GitLab)

added Changed fusiondirectory-core and removed Bugs labels

By bmortier on 2019-01-11T14:10:50 (imported from GitLab)