Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory fusiondirectory
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectoryfusiondirectory
  • Issues
  • #2361
Something went wrong while setting issue due date.
Closed
Open
Issue created 12 years ago by bmortier@bmortierMaintainer
  • New related issue

  • New related issue

Login uses simple quotes for translated strings in smarty template

Closed

Login uses simple quotes for translated strings in smarty template

Hello,

When using translated strings in template, such thing is dangerous: @{t}Username{/t}@ For instance, in French the translation of Username is Nom d'utilisateur, so the the simple quote break the html attribute. Using double quotes should avoid such problems as they are usually not used in translations.

(from redmine: issue id 2361, created on 2013-05-03, closed on 2013-05-07)

  • Changesets:
    • Revision 75978f1d by Côme Chilliet on 2013-05-03T17:48:41.000Z:
Fixes: #2361 Login uses simple quotes for translated strings in smarty template
  • Revision 5b61bb67 by Côme Chilliet on 2013-05-03T17:51:26.000Z:
Fixes: #2361 Login uses simple quotes for translated strings in smarty template
  • Revision 28a1fd49 by Côme Chilliet on 2013-05-07T08:41:05.000Z:
Fixes: #2361 avoiding simple quotes around translations
  • Custom Fields:
    • Bug in version: 1.0.5
  • Uploads:
    • 0001-Fixes-2361-Login-uses-simple-quotes-for-translated-s.patch
    • 0002-Fixes-2361-avoiding-simple-quotes-around-translation.patch

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Linked items
    0

    Link issues together to show that they're related. Learn more.

    Activity


    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      This fixes this problem in login.tpl by using double quotes.

      (from redmine: written on 2013-05-03)

      By Côme Chilliet on 2017-09-02T14:59:05 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      Hello,

      so :) you can check the rest of the template for the core :) do i need to enter another bug or will you put all patches here ?

      Cheers

      (from redmine: written on 2013-05-03)

      By bmortier on 2017-09-02T14:59:05 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      Hello,

      I've tested for login and it's ok

      Cheers

      (from redmine: written on 2013-05-06)

      By gdivito on 2017-09-02T14:59:05 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      Close issue

      (from redmine: written on 2013-05-06)

      By bmortier on 2017-09-02T14:59:06 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      Reopen issue

      (from redmine: written on 2013-05-07)

      By Côme Chilliet on 2017-09-02T14:59:07 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      This is for the other templates

      (from redmine: written on 2013-05-07)

      By Côme Chilliet on 2017-09-02T14:59:08 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      it seems to be ok

      cheers

      (from redmine: written on 2013-05-07)

      By gdivito on 2017-09-02T14:59:08 (imported from GitLab)

    • bmortier
      bmortier @bmortier · 12 years ago
      Author Maintainer

      Close issue

      (from redmine: written on 2013-05-07)

      By gdivito on 2017-09-02T14:59:08 (imported from GitLab)

    • bmortier closed 7 years ago

      closed

      By bmortier on 2017-09-02T14:59:06 (imported from GitLab)

    • bmortier reopened 7 years ago

      reopened

      By Côme Chilliet on 2017-09-02T14:59:07 (imported from GitLab)

    • bmortier closed 7 years ago

      closed

      By gdivito on 2017-09-02T14:59:08 (imported from GitLab)

    • bmortier added Fixed fusiondirectory-core and removed Bugs labels 6 years ago

      added Fixed fusiondirectory-core and removed Bugs labels

      By bmortier on 2019-01-11T20:52:43 (imported from GitLab)

    Please register or sign in to reply
    Assignee
    bmortier's avatar
    bmortier
    Assign to
    Labels
    0
    None
    0
    None
      Assign labels
    • Manage project labels

    Milestone
    No milestone
    None
    Due date
    None
    None
    None
    Time tracking
    No estimate or time spent
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

    Lock issue
    Unlocked
    1
    1 Participant
    bmortier
    Reference:

    Menu

    Explore Projects Groups Topics Snippets