Template system should be redone
Template system should be redone
The template system should allow to use any attributes in any other one. It should also be made available for any object, not just users.
Here's an idea: We could do a new schema with a multi-valuated templateValue field that would store values with 'ldapField:value' syntax. It would allow to use %attribute% even in fields that only allow numbers or such. We must use the @%attribute%@ syntax and not the @%attribute@ one, as said in #1711 (closed). We would need some way to guess what fields should be asked to the user when the template is used. My guess is : fields that are mandatory + fields that are used in other field values + some way to manually indicate we wanna ask a field, for instance @%askme%@ syntax.
(from redmine: issue id 1887, created on 2013-01-24, closed on 2015-06-24)
- Relations:
- relates #3845
- relates #4358
- copied_to #2535
- Changesets:
- Revision e6f07bb7 by Côme Chilliet on 2013-06-28T07:40:10.000Z:
Fixes: #1887 First draft of new template system- Revision 4b5c614d by Côme Chilliet on 2013-06-28T07:44:31.000Z:
Fixes: #1887 First template system draft- Revision dc2c4665 by Côme Chilliet on 2013-06-28T16:36:58.000Z:
Fixes: #1887 Continuing implementation of new template system- Revision 51e2d0e9 by Côme Chilliet on 2013-07-17T15:46:09.000Z:
Fixes: #1887 Fixing template display in user list- Revision 9bdf45a3 by Côme Chilliet on 2013-07-18T15:07:19.000Z:
Fixes: #1887 Template are now partly working- Revision c8375189 by Côme Chilliet on 2013-07-19T08:02:45.000Z:
Fixes: #1887 Fixes code style small errors- Revision 5387ddcf by Côme Chilliet on 2013-08-02T15:08:41.000Z:
Fixes: #1887 Fixed user edition links (added PID)- Revision adfdb74c by Côme Chilliet on 2014-09-08T08:27:33.000Z:
Fixes #1887 Fixed template_cn handling- Revision 1339d15a by Côme Chilliet on 2014-09-09T11:43:08.000Z:
Fixes #1887 Added proper template handling- Revision 1d98e63e by Côme Chilliet on 2014-09-16T09:43:18.000Z:
Fixes #1887 Fixed template creation menu style- Revision f0711d63 by Côme Chilliet on 2014-10-14T15:24:16.000Z:
Fixes #1887 Added functions in template for csv import plugin- Revision f7a4fbfc by Côme Chilliet on 2014-10-15T16:43:15.000Z:
Fixes #1887 Do not show disabled tabs attributes in plugin
Also use uppercase in departements type list- Revision 2f461a30 by Côme Chilliet on 2014-10-20T09:56:52.000Z:
Fixes #1887 Added serialize features for templates
This will be used for imports and webservice- Revision 043b8797 by Côme Chilliet on 2015-03-31T16:29:26.000Z:
Fixes: #1887 Continuing implementation of new template system
Conflicts:
contrib/openldap/template-fd.schema
include/class_plugin.inc
plugins/admin/groups/class_group.inc
plugins/admin/ogroups/objectSelect/selectObject-filter.xml
plugins/admin/users/user-list.xml
plugins/personal/generic/class_user.inc
plugins/personal/posix/class_posixAccount.inc
plugins/personal/posix/trustSelect/trust-filter.xml- Revision c74a4a01 by Côme Chilliet on 2015-03-31T16:34:28.000Z:
Fixes: #1887 Template are now partly working
Conflicts:
include/class_plugin.inc
include/functions.inc
plugins/admin/users/class_userManagement.inc
plugins/personal/posix/class_posixAccount.inc- Revision e272ca8c by Côme Chilliet on 2015-03-31T16:35:32.000Z:
Fixes #1887 Fixed template_cn handling- Revision 533d2fd2 by Côme Chilliet on 2015-03-31T16:37:31.000Z:
Fixes #1887 Added proper template handling
Conflicts:
plugins/admin/users/class_userManagement.inc
plugins/personal/generic/class_user.inc
setup/class_setupStep_Migrate.inc- Revision ac202013 by Côme Chilliet on 2015-03-31T16:37:47.000Z:
Fixes #1887 Fixed template creation menu style- Revision ba84c8a4 by Côme Chilliet on 2015-03-31T16:38:00.000Z:
Fixes #1887 Added functions in template for csv import plugin- Revision 01522923 by Côme Chilliet on 2015-03-31T16:38:12.000Z:
Fixes #1887 Do not show disabled tabs attributes in plugin
Also use uppercase in departements type list- Revision 5d9bbb1c by Côme Chilliet on 2015-03-31T16:38:24.000Z:
Fixes #1887 Added serialize features for templates
This will be used for imports and webservice- Revision b80a4886 by Côme Chilliet on 2015-04-30T15:01:05.000Z:
Fixes #1887 Fixed tab activation in templates- Revision 45436fb7 by Côme Chilliet on 2015-04-30T15:01:20.000Z:
Fixes #1887 Fixed tab activation in templates- Revision 1240a78e by Côme Chilliet on 2015-06-06T17:37:58.000Z:
Fixes #1887 Fixed some problems with templates, added askme- Revision 359f6228 by Côme Chilliet on 2015-06-06T17:38:28.000Z:
Fixes #1887 Fixed some problems with templates, added askme- Revision 1d9edf11 by Côme Chilliet on 2015-06-06T17:38:47.000Z:
Fixes #1887 fixed tab disabling in templates- Revision e5b9153a by Côme Chilliet on 2015-06-06T17:39:11.000Z:
Fixes #1887 fixed tab disabling in templates- Revision b8058688 by Côme Chilliet on 2015-06-08T16:51:39.000Z:
Fixes #1887 fixes PHP errors- Revision 98618dc9 by Côme Chilliet on 2015-06-08T16:52:00.000Z:
Fixes #1887 fixes PHP errors- Revision 63e44d23 by Côme Chilliet on 2015-06-09T16:34:32.000Z:
Fixes #1887 Fixed user creation using a template- Revision ba3af3de by Côme Chilliet on 2015-06-09T16:34:49.000Z:
Fixes #1887 Fixed user creation using a template- Revision dd76239c by Côme Chilliet on 2015-06-11T13:16:32.000Z:
Fixes #1887 Added menu entry to create user from template- Revision a06c0cce by Côme Chilliet on 2015-06-11T13:16:45.000Z:
Fixes #1887 Added menu entry to create user from template- Custom Fields:
- Bug in version: 1.0.8.1
- Uploads:
- 0001-Added-some-methods-for-template-handling-1887.patch
- 0001-Template-LDAP-schema-draft-no-ID-yet.patch
- 0001-Fixes-1887-First-draft-of-new-template-system.patch
- 0002-Fixes-1887-Continuing-implementation-of-new-template.patch
- 0003-Fixes-1887-Fixing-template-display-in-user-list.patch
- 0004-Fixes-1887-Template-are-now-partly-working.patch
- 0005-Fixes-1887-Fixes-code-style-small-errors.patch
- 0006-Fixes-1887-Fixed-user-edition-links-added-PID.patch
- 0007-Fixes-1887-Fixed-template_cn-handling.patch
- 0008-Fixes-1887-Added-proper-template-handling.patch
- 0009-Fixes-1887-Fixed-template-creation-menu-style.patch
- 00010-Fixes-1887-Added-functions-in-template-for-csv-impor.patch
- 00011-Fixes-1887-Do-not-show-disabled-tabs-attributes-in-p.patch
- 00012-Fixes-1887-Added-serialize-features-for-templates.patch
- 00012-Fixes-1887-Fixed-tab-activation-in-templates.patch
- 00013-Fixes-1887-Fixed-some-problems-with-templates-added-.patch
- 00014-Fixes-1887-fixed-tab-disabling-in-templates.patch
- 00015-Fixes-1887-fixes-PHP-errors.patch
- 00016-Fixes-1887-Fixed-user-creation-using-a-template.patch
- 00017-Fixes-1887-Added-menu-entry-to-create-user-from-temp.patch
Activity
Some notes about this: tabs constructor already takes a $attrs_object (which is used for copy/paste), we can use this for providing a fake $attrs. Instead of saving, we would need to call an other tabs method that only calls prepare_save, and then translate the resulting attrs into template-formed one. Maybe add a template_save method to simplePlugin. (and/or tabs) We may need some way to tell attributes they are rendered for a template (In most cases not calling check might do the trick but not always. For instance we need date and int not to translate their value into date/int) We will also have problems with attributes that alter other objects (group membership, services, …)
(from redmine: written on 2013-06-14)
By Côme Chilliet on 2017-09-02T14:54:47 (imported from GitLab)
Next step : modify tpl_parse method so that we can use it to work on the LDAP attributes array. (Meaning when building a user from a template, we need to translate from template attrs to user attrs, and then tpl_parse it to resolve %% masks)
(from redmine: written on 2013-07-17)
By Côme Chilliet on 2017-09-02T14:54:47 (imported from GitLab)
It work very well for the usertab but not with other.
I try to force displaying of homeDirectory to set %homeDirectory% in default mandatory field but nothing appear.
We missed %askme% too.
Cheers.
(from redmine: written on 2015-05-26)
By Jonathan Swaelens on 2017-09-02T14:54:49 (imported from GitLab)
Sorry it work for the mandatory in the other tabs.
But I have 2 others problems.
When I create a template I have these PHP Errors (see screenshots)
And when I try to copy a template I have this error
https://paste.opensides.be/?b60b083e5c0e1fb7#Lnl0gm4y/LowEgn56EK1Ko/rcvUwlnV4ZLyLeOtTa8Y=
(from redmine: written on 2015-06-08)
By Jonathan Swaelens on 2017-09-02T14:54:50 (imported from GitLab)
