fix(core) Replace pow by ** operator

PHP now has an exponentiation operator ** that can be used instead of
 the pow function.

issue #5827

include/functions.inc

@@ -1367,7 +1367,7 @@ function normalize_netmask($netmask)
 
       for ($i = 7; $i >= 0; $i--) {
         if ($num-- > 0) {
-          $result += pow(2, $i);
+          $result += 2 ** $i;
         }
       }
 
@@ -1418,7 +1418,7 @@ function netmask_to_bits($netmask)
         $res += 8 - $i;
         break;
       }
-      $start -= pow(2, $i);
+      $start -= 2 ** $i;
     }
   }
 
@@ -1499,7 +1499,7 @@ function gen_uids($rule, $attributes)
       $size = $m[2];
 
       $start = ($m[1] == ":" ? 0 : -1);
-      for ($i = $start, $p = pow(10, $size) - 1; $i < $p; $i++) {
+      for ($i = $start, $p = (10 ** $size) - 1; $i < $p; $i++) {
         if ($i == -1) {
           $number = "";
         } else {
@@ -1523,7 +1523,7 @@ function gen_uids($rule, $attributes)
 
       while (TRUE) {
         mt_srand((double)microtime() * 1000000);
-        $number = sprintf("%0".$size."d", mt_rand(0, pow(10, $size) - 1));
+        $number = sprintf("%0".$size."d", mt_rand(0, (10 ** $size) - 1));
         $res    = preg_replace('/{id#(\d+)}/', $number, $uid);
         $ldap->search('(uid='.ldap_escape_f(preg_replace('/[{}]/', '', $res)).')', array('dn'));
         if ($ldap->count() == 0) {
@@ -1614,7 +1614,7 @@ function humanReadableSize ($bytes, $precision = 2)
   }
   $base = log($bytes) / log(1024);
 
-  return sprintf($format[floor($base)], round(pow(1024, $base - floor($base)), $precision));
+  return sprintf($format[floor($base)], round(1024 ** ($base - floor($base)), $precision));
 }
 
 

include/simpleplugin/class_helpersAttribute.inc

@@ -265,11 +265,11 @@ class BytesSizeAttribute extends UnitIntAttribute
   function __construct ($label, $description, $ldapName, $required, $min = FALSE, $max = FALSE, $defaultValue = "", $acl = "")
   {
     $units = array(
-      1             => _('B'),
-      pow(1024, 1)  => _('KiB'),
-      pow(1024, 2)  => _('MiB'),
-      pow(1024, 3)  => _('GiB'),
-      pow(1024, 4)  => _('TiB'),
+      1         => _('B'),
+      1024 ** 1 => _('KiB'),
+      1024 ** 2 => _('MiB'),
+      1024 ** 3 => _('GiB'),
+      1024 ** 4 => _('TiB'),
     );
     parent::__construct ($label, $description, $ldapName, $required, $units, $min, $max, $defaultValue, $acl);
   }

[bmortier]

SonarQube analysis reported 51 issues

• 1 critical
• 38 major
• 4 minor
• 8 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

1. Move this "case default" clause to the end of this "switch" statement.
2. Remove the unused function parameter "$headline".
3. Define and throw a dedicated exception instead of using a generic one.
4. Review the data-flow - use of uninitialized value.
5. Define and throw a dedicated exception instead of using a generic one.
6. Define and throw a dedicated exception instead of using a generic one.
7. Remove the unused function parameter "$classes".
8. Remove the unused function parameter "$entry".
9. Reduce the number of returns of this function 4, down to the maximum allowed 3.
10. Remove the unused function parameter "$type".

• ... 41 more

By Ghost User on 2018-05-02T14:19:38 (imported from GitLab)