Skip to content
GitLab
Commit ef77ec85 authored by Côme Chilliet's avatar Côme Chilliet
Browse files

:ambulance: fix(webservice) Do not let webservice request set disabled attributes 

It seems deserializeValue method in Attribute was actually unused,
 setValue being called directly by simplePlugin.
Now it’s used and does about the same thing as setValue, just returns an
 error if the attribute is disabled.

issue #5811
parent 2cead23f
dev 6342-update-the-locales-for-1-5 6344-template-issue-when-creating-a-template-with-empty-password-error-message-should-not-be-seen 6365-core-locking-mechanism-is-not-changing-the-mail-ressource-it-does-lock-the-mail-account 6365-core-when-lock-mechanism-is-trigger-the-user-should-not-be-editable-if-not-unlock 6378-orcid-test-method-is-wrong-and-break-orcid-saving 6379-core-ogroups-creation-with-backend-default-user-available-for-selection core-php8 master fusiondirectory-1.5 fusiondirectory-1.4 fusiondirectory-1.3.1 fusiondirectory-1.3
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 17 additions and 23 deletions
+17 -23
  • bmortier @bmortier ·
    Maintainer

    SonarQube analysis reported 3 issues

    • :warning: 3 major

    Watch the comments in this conversation to review them.

    1 extra issue

    Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

    1. :warning: Reduce the number of returns of this function 4, down to the maximum allowed 3. :blue_book:

    By Ghost User on 2018-04-17T13:51:56 (imported from GitLab)

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment