Merge branch 'stricter-ldap-error-check' into '1.4-dev'

 fix(ldap) Use a stricter error check in ldap::success()

See merge request fusiondirectory/fd!648

(cherry picked from commit 29ca9876)

23936352  fix(ldap) Use a stricter error check in ldap::success()

include/class_ldap.inc

@@ -881,7 +881,7 @@ class LDAP
    */
   function success()
   {
-    return preg_match('/Success/i', $this->error);
+    return (trim($this->error) === 'Success');
   }
 
   /*!

[bmortier]

SonarQube analysis reported 1 issue

• 1 minor

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

1. Rename class "tabs_configInLdap" to match the regular expression ^[a-zA-Z][a-zA-Z0-9]*$.

By Ghost User on 2019-07-29T11:55:03 (imported from GitLab)