:sparkels: feat(core) Add CSRF protection token

issue #5840

html/main.php

 <?php
-
 /*
   This code is part of FusionDirectory (http://www.fusiondirectory.org/)
   Copyright (C) 2003-2010  Cajus Pollmeier
-  Copyright (C) 2011-2016  FusionDirectory
+  Copyright (C) 2011-2018  FusionDirectory
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -54,6 +53,8 @@ if (!session::global_is_set('connected')) {
   exit;
 }
 
+CSRFProtection::check();
+
 $ui     = session::global_get('ui');
 $config = session::global_get('config');
 
@@ -324,7 +325,8 @@ if (session::is_set('errors') && session::get('errors') != "") {
 $focus = '<script type="text/javascript">';
 $focus .= 'next_msg_dialog();';
 $focus .= '</script>';
-$smarty->assign("focus", $focus);
+$smarty->assign('focus',      $focus);
+$smarty->assign('CSRFtoken',  CSRFProtection::getToken());
 
 /* Set channel if needed */
 //TODO: * move all global session calls to global_

html/setup.php

@@ -49,6 +49,8 @@ session::start();
 session::global_set('DEBUGLEVEL', 0);
 session::set('errorsAlreadyPosted', array());
 
+CSRFProtection::check();
+
 /* Attribute initialization, reset errors */
 reset_errors();
 
@@ -123,6 +125,7 @@ $smarty->assign("navigation",     $setup->get_navigation_html());
 $smarty->assign("headline_image", $setup->get_header_image());
 $smarty->assign("headline",       $setup->get_header_text());
 $smarty->assign("focus",          $focus);
+$smarty->assign('CSRFtoken',      CSRFProtection::getToken());
 $smarty->assign("msg_dialogs",    msg_dialog::get_dialogs());
 
 if ($error_collector != "") {

ihtml/themes/breezy/framework.tpl

@@ -55,6 +55,7 @@
     {$errors}
     {$focus}
     <input type="hidden" name="php_c_check" value="1"/>
+    <input type="hidden" name="CSRFtoken" value="{$CSRFtoken}"/>
   </form>
 
 

include/class_CSRFProtection.inc

+<?php
+/*
+  This code is part of FusionDirectory (http://www.fusiondirectory.org/)
+  Copyright (C) 2017-2018 FusionDirectory
+
+  This program is free software; you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation; either version 2 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program; if not, write to the Free Software
+  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+*/
+
+class CSRFProtection
+{
+  public static function check()
+  {
+    if (empty($_POST)) {
+      return;
+    }
+    if (empty($_POST['CSRFtoken'])) {
+      throw new Exception('CSRF protection token missing');
+    }
+
+    $validToken = static::getToken();
+    if ($_POST['CSRFtoken'] !== static::getToken()) {
+      throw new Exception('CSRF protection token invalid');
+    }
+  }
+
+  public static function getToken()
+  {
+    if (!session::is_set('CSRFtoken')) {
+      session::set('CSRFtoken', standAlonePage::generateRandomHash());
+    }
+    return session::get('CSRFtoken');
+  }
+}

setup/setup_frame.tpl

@@ -39,6 +39,7 @@
     {$errors}
     {$focus}
     <input type="hidden" name="setup_goto_step" value=""/>
+    <input type="hidden" name="CSRFtoken" value="{$CSRFtoken}"/>
   </form>
 
 </body>

[bmortier]

Define and throw a dedicated exception instead of using a generic one.

By Ghost User on 2018-06-04T12:45:42 (imported from GitLab)

[bmortier]

Remove this unused "$validToken" local variable.

By Ghost User on 2018-06-04T12:45:41 (imported from GitLab)

[bmortier]

Define and throw a dedicated exception instead of using a generic one.

By Ghost User on 2018-06-04T12:45:42 (imported from GitLab)

[bmortier]

SonarQube analysis reported 3 issues

• 3 major

Watch the comments in this conversation to review them.

By Ghost User on 2018-06-04T12:45:43 (imported from GitLab)