feat(sonar) Add support for sonar in 1.4-dev

Signed-off-by: Benoit Mortier <benoit.mortier@opensides.be>

.gitlab-ci.yml

@@ -92,12 +92,12 @@ sonar_publish:
   image: sonar-cli:3.1.0.1141
   stage: codestyle
   only:
-    - 1.3-dev
+    - 1.4-dev
   script:
     - /home/sonar/*/bin/sonar-scanner
-      -D sonar.projectKey=fusiondirectory-dev
-      -D sonar.projectName=FusionDirectory-Dev
-      -D sonar.projectVersion=1.3
+      -D sonar.projectKey=fusiondirectory-1.4-dev
+      -D sonar.projectName=FusionDirectory-1.4-Dev
+      -D sonar.projectVersion=1.4
       -D sonar.sourceEncoding=UTF-8
       -D sonar.exclusions='html/themes/legacy/**/*,include/class_xml.inc'
       -D sonar.gitlab.project_id="$CI_PROJECT_PATH"
@@ -109,12 +109,12 @@ sonar_preview:
   image: sonar-cli:3.1.0.1141
   stage: codestyle
   except:
-    - 1.3-dev
+    - 1.4-dev
   script:
     - /home/sonar/*/bin/sonar-scanner
-      -D sonar.projectKey=fusiondirectory-dev
-      -D sonar.projectName=FusionDirectory-Dev
-      -D sonar.projectVersion=1.3
+      -D sonar.projectKey=fusiondirectory-1.4-dev
+      -D sonar.projectName=FusionDirectory-1.4-Dev
+      -D sonar.projectVersion=1.4
       -D sonar.sourceEncoding=UTF-8
       -D sonar.exclusions='html/themes/legacy/**/*,include/class_xml.inc'
       -D sonar.gitlab.project_id="$CI_PROJECT_PATH"

[bmortier]

SonarQube analysis reported 351 issues

• 4 blocker
• 252 major
• 86 minor
• 9 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

1. Remove the use of this variable variable "$$attr".
2. Remove the use of this variable variable "$$vars_name".
3. Remove the use of this variable variable "$$vars_name".
4. Remove the use of this variable variable "$$vars_name".
5. Remove the unused function parameter "$smarty".
6. Merge this if statement with the enclosing one.
7. Remove the unused function parameter "$smarty".
8. Remove the unused function parameter "$smarty".
9. Rename "$mail_body" which has the same name as the field declared at line 258.
10. Rename "$mail_body" which has the same name as the field declared at line 258.

• ... 341 more

By Ghost User on 2018-05-02T18:55:12 (imported from GitLab)