Merge branch '6146-php-errors-on-failed-login' into '1.4-dev'

Resolve "PHP errors on failed login"

See merge request fusiondirectory/fd!866

include/login/class_LoginPost.inc

@@ -66,19 +66,19 @@ class LoginPost extends LoginMethod
         'runSchemaCheck',
       ]);
 
-      /* If needed redirect to second factor page */
-      $secondFactor = FALSE;
-      foreach (static::$secondFactorMethods as $secondFactorMethod) {
-        if (!class_available($secondFactorMethod)) {
-          continue;
+      if ($success) {
+        /* If needed redirect to second factor page */
+        $secondFactor = FALSE;
+        foreach (static::$secondFactorMethods as $secondFactorMethod) {
+          if (!class_available($secondFactorMethod)) {
+            continue;
+          }
+          $secondFactor = ($secondFactorMethod::hasSecondFactor() || $secondFactor);
+        }
+        if ($secondFactor) {
+          static::redirectSecondFactorPage();
         }
-        $secondFactor = ($secondFactorMethod::hasSecondFactor() || $secondFactor);
-      }
-      if ($secondFactor) {
-        static::redirectSecondFactorPage();
-      }
 
-      if ($success) {
         /* Everything went well, redirect to main.php */
         static::redirect();
       }