fix(simpleplugin) Call update on all tabs instead of only current one.

Calling update method is usually cheap, and tabs may update in reaction
 to changes in other tabs, so it’s better to update all tabs instead of
 only last and current ones. It will improve behavior of webservice as
 well.

issue #6159

include/simpleplugin/class_simpleTabs.inc

@@ -241,12 +241,11 @@ class simpleTabs implements FusionDirectoryDialog
 
   public function update (): bool
   {
-    if (($this->last != $this->current) && ($this->last != '')) {
-      $this->by_object[$this->last]->update();
+    /* Call update on all tabs as they may react to changes in other tabs */
+    foreach ($this->by_object as $key => $obj) {
+      $obj->update();
     }
 
-    $this->by_object[$this->current]->update();
-
     return TRUE;
   }
 

[bmortier]

Remove this unused "$key" local variable.

By sonar gitlab-ci on 2021-04-27T09:10:50 (imported from GitLab)

[bmortier]

SonarQube analysis reported 1 issue

• 1 major

Watch the comments in this conversation to review them.

By sonar gitlab-ci on 2021-04-27T09:10:51 (imported from GitLab)