Merge branch '5135-filter-enhancement-and-management-refactor' into '1.4-dev'

Resolve "filter enhancement and management refactor"

See merge request fusiondirectory/fd!527

include/management/columns/class_Column.inc

@@ -175,6 +175,15 @@ class Column
     $value = $this->getAttributeValue($entry);
     if ($value == '') {
       return ' ';
+    } elseif (is_array($value)) {
+      $value = array_map(
+        function ($v)
+        {
+          return htmlentities($v, ENT_COMPAT, 'UTF-8');
+        },
+        $value
+      );
+      return implode("<br/>\n", $value);
     } else {
       return htmlentities($value, ENT_COMPAT, 'UTF-8');
     }

include/management/columns/class_LinkColumn.inc

@@ -25,23 +25,7 @@ class LinkColumn extends Column
 {
   function renderCell(ListingEntry $entry)
   {
-    $value = $this->getAttributeValue($entry);
-    if ($value == '') {
-      return ' ';
-    } else {
-      if (is_array($value)) {
-        $value = array_map(
-          function ($v)
-          {
-            return htmlentities($v, ENT_COMPAT, 'UTF-8');
-          },
-          $value
-        );
-        return $this->renderLink($entry, implode("<br/>\n", $value));
-      } else {
-        return $this->renderLink($entry, htmlentities($value, ENT_COMPAT, 'UTF-8'));
-      }
-    }
+    return $this->renderLink($entry, parent::renderCell($entry));
   }
 
   protected function renderLink(ListingEntry $entry, $htmlValue)

[bmortier]

SonarQube analysis indicates that quality gate is failed.

• Security Rating on New Code is passed: Actual value 1
• Reliability Rating on New Code is failed: Actual value 3 > 1
• Maintainability Rating on New Code is passed: Actual value 1
• Duplicated Lines on New Code (%) is passed: Actual value 3.063365505665128

SonarQube analysis reported no issues.

By Ghost User on 2019-02-11T14:57:14 (imported from GitLab)