fatal error in invitations plugin when trying to access a private form

Description

Getting a fatal error when trying to access to a private form.

Distribution Name and Version

debian:bullseye-slim

FusionDirectory Version

1.4-1

Plugin with the defect

Invitations

PHP version used

php7.4

Origin of php packages

apt-cache policy php7.4 php7.4: Installed: 7.4.33-1+deb11u7 Candidate: 7.4.33-1+deb11u7 Version table: *** 7.4.33-1+deb11u7 500 500 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages 100 /var/lib/dpkg/status 7.4.33-1+deb11u5 500 500 http://deb.debian.org/debian bullseye/main amd64 Packages

Steps to Reproduce

0. Create a Public Form and set it in private
1. Create an invitation for this form and send it to your own mail
2. Go to the link received in the mail (e.g. http://test.example.com:81/invitation.php?token=zF1dhkwypFYFfystmwFzeMW6jHCfm9mOqbn3xOWLptXDnT3wqnFQKYSyr)
3. Click on "Click here to login" or "Click here if you can't login"
4. Get redirected on http://test.example.com:81/privateform.php?token=zF1dhkwypFYFfystmwFzeMW6jHCfm9mOqbn3xOWLptXDnT3wqnFQKYSyr and get the error I showed above.

Actual behavior:

I get this error : Erreur Fatale Non attrapé : Error : Call to a member function inputValue() on null

When I refresh the page, I don't have the error any more and the private form ends up being displayed without me having to log in. The same thing happens wether I click on "Click here to login" or "Click here if you can't login".

Expected behavior:

The form is private so when I click on "Click here to login" it should actually ask me to login and the option "Click here if you can't login" should not be displayed, or at least shouldn't let me access the form.

Additional Information

I don't know if it's relevant but here's my apache config :

cat /etc/apache2/sites-available/000-default.conf
Listen 81

<VirtualHost *:81>
    ServerAdmin admin@test.example.com
    ServerName test.example.com
    DocumentRoot /usr/share/fusiondirectory/html
    <Directory /usr/share/fusiondirectory/html>
        Options FollowSymLinks
        AllowOverride All
        Require all granted
    </Directory>
    ErrorLog ${APACHE_LOG_DIR}/fusiondirectory_error.log
    CustomLog ${APACHE_LOG_DIR}/fusiondirectory_access.log combined
</VirtualHost>

It's my first time creating an issue here, let me know if you need more information.

added plugin-invitations label

assigned to @jswaelens

added PJ1802-0188 label

assigned to @tdockx and unassigned @jswaelens

changed milestone to %FusionDirectory 1.6

Hello @mluongo

Thanks for the report, we will look into it

Cheers

I am verifying with development build if the issue is happening.

changed time estimate to 4h

added 15m of time spent

Dear @mluongo,

In the development - latest build - I do not have the issue. But my environment is clearly different from yours.

I used pure HTTPS with domain name, no port 81, potentially having issue with headers received.

I tried with HTTP and changing the configuration of my Apache to match yours. Although the emails sent from invitation are with a link received with HTTPS, I simply changed it to http with port 81, I don't have the problem to access either redirect.

Could you share with us the email received from invitation ? I guess it is with port 81, but I want to be sure of it.

Thank you.

EDIT: The behavior you wish to have is indeed correct. You should see the template directly.

I'll come back to you as soon as I have an intance running 1.4

Hello @tdockx,

Thank you for your feedback. The invitation email indeed contains a link using http with port 81 :

Please subscribe by going to http://test.example.com:81/invitation.php?token=MbrzC9HPnqpQyh2qyeemFawLX81gtrE99Q9YLCOXZFzXp1EZ669ZQWK8T

I replaced https with http in the fdInvitationEmailContent attribute.

If you identify any further insights while testing version 1.4, feel free to let me know.

Dear @mluongo,

I have successfully replicated your issue on the stable release of FusionDirectory 1.4.

However, I did not encounter the same problem on the latest development version.

FusionDirectory 1.5 is set to be released very soon and should include a fix for this issue.

I hope this helps! Please let me know if you have any further questions.

@tdockx thank you for investigating the issue. I'll be waiting for 1.5 then. The plugin, however, is not exactly what I thought it would be but I guess I should open another issue for that.

yes please open ticket for ideas or improvement

There's one already #6262 So I just left a comment.

@mluongo

so in FusionDirectory invitations plugin work correctly without error, if so i will close this ticket

Cheers

added 25m of time spent

added 1h of time spent

added 5m of time spent

added 5m of time spent