[webservice] - supannCMSId et supannCMSAppId - Attributes filtering issue

Description

It seems the output during a filtering on supannCMS components do not work whil using the webservice.

Distribution Name and Version

Debian 11

FusionDirectory Version

1.4

Plugin with the defect

Webservice

PHP version used

7.4

Origin of php packages

Enterprise

Steps to Reproduce

CURL command can be use. Client command here enclosed :

GET /objects/user?base=ou=active,dc=int-evry,dc=fr&filter=(uid=test)&attrs\[supannCMSAppId\]=\*&attrs\[supannCMSId\]=\*&attrs\[supannCMSAppAffectation\]=\*

Expected behavior:

A proper output if filter and attributes arguments are used.

Actual behavior:

• if attrs[supannCMSAppId]=*, nothing happens.
• if attrs[supannCMSAppId;x-koha-xmsb]=*, ACL issue is generated.

Reproduces how often:

100%.

Additional Information

Important to see if REST tools can be used to reproduce the problem. Curl script from the team does not report any issue apart from void data displayed.

changed due date to June 02, 2022

changed milestone to %FusionDirectory 1.4

assigned to @tdockx

I could indeed reproduce the issue.

For supannCMSAppID attributes equals to all

http://localhost/fusiondirectory/rest.php/v1/objects/user/?base=ou%3Dpeople,dc%3Dhome&filter=(uid%3Djonathan)&attrs%5BsupannCMSAppId%5D=*

Only : {} is returned.

ForsupannCMSAppId;x-koha-xmsb attributes equals to all

http://localhost/fusiondirectory/rest.php/v1/objects/user/?base=ou%3Dpeople,dc%3Dhome&filter=(uid%3Djonathan)&attrs%5BsupannCMSAppId%3Bx-koha-xmsb%5D=*

The following is being returned.

[
	{
		"class": "FusionDirectoryException",
		"message": "Could not find ACL for attribute \"supannCMSAppId;x-koha-xmsb\" for type \"user\"",
		"line": 95,
		"file": "/usr/share/fusiondirectory/include/class_objects.inc"
	}
]

Hello @bmortier @jswaelens,

Is it possible that FD ACL does not work with LDAP options ?

A quick and dirty fix on the object class (class_objects.inc) Adding line 93:

$search_attr = str_replace(';x-koha-xmsb', '', $search_attr);

This makes webservice happy and showing the proper data.

From:

[
	{
		"class": "FusionDirectoryException",
		"message": "Could not find ACL for attribute \"supannCMSAppId;x-koha-xmsb\" for type \"user\"",
		"line": 96,
		"file": "/usr/share/fusiondirectory/include/class_objects.inc"
	}
]

To:

{
	"uid=jonathan,ou=people,dc=home": {
		"supannCMSAppId;x-koha-xmsb": [
			"1"
		]
	}
}

EDIT 1 : LDAP options are indeed not being taken into account by ACL, a new verification function to remove ldap options during ACL check will be implemented. (Testing to verify impact on registration must be performed after).

created branch 6171-webservice-supanncmsid-et-supanncmsappid-attributes-filtering-issue to address this issue

Note : closing this issue as following one was created within core.

closed

reopened

added 3h of time spent

closed

added PJ2203-0467 label

added fusiondirectory-core label

added won't fix label

added telecom sud paris label