Some webservice actions only works on simplePlugin classes

There are 4 REST operations which tests is_subclass_of($object, 'simplePlugin'), they should be adapted to be able to work with any SimpleTab instance.

This should allow more operations to work on network interfaces.

fdRPCService class should also be checked for such limitations.

changed milestone to %FusionDirectory 1.4

added PJ1802-0188 plugin-webservice labels

mentioned in commit 0cdb433b

mentioned in commit 4a5d8ada

Some methods are fixed.

Some others still needs adaptation or tests, especially in all instances where sections are used (only simplePlugin instances organize attributes by section).

added 1h of time spent

changed due date to August 05, 2021

marked this issue as related to #6143 (closed)

Current status:

• listObjectTabs
• modifyObject
• modifyObjectTab
• getObjectTab ✘ Invalid tab
• getAttributeValues
• setAttributeValues (But see #6143 (closed) for interfaces special case)
• resetAttributeValue ✘ Type error (Maybe specific to interfaces)
• getTypeInfo
• getTabInfo ✘ Invalid tab

hello @cchilliet

you can work on fixing those

Cheers

resetAttributeValue Fixed in #6143 (closed), it was specific to interfaces.

@bmortier For getTabInfo, it’s supposed to return a list of sections, with for each sections its name and the list of attributes, for instance:

GET /types/server/serverGeneric
{
  "sections": {
    "main": {
      "name": "Properties",
      "attrs": [
        "base",
        "cn",
        "description",
        "l",
        "fdMode",
        "ipHostNumber",
        "macAddress"
      ]
    }
  },
  "sections_order": [
    "main"
  ]
}

For tabs which do not inherit simplePlugin, the attributes are not grouped into sections, so I will return them all as in a default section, which I think should have the id "main" as its often the case in FusionDirectory, but what should be put in name? I see 3 possibilities:

1. Do not set the name key in this case
2. Set it to an empty value: ""
3. Set it to the name of the tab

First solution may break algorithm expecting all tabs to return the same keys. Second one may result in weird output or CLI or GUI using an empty string as the name. Third one may result in duplicate tab name as section name, and makes it harder for the caller to detect that this is not a real section.

after discussing it the option 2 is chosen

mentioned in commit 1bff174c

added 3h of time spent

added To Be Tested label

All selenium tests for this passed: https://gitlab.fusiondirectory.org/debian/buster-fusiondirectory-dev/-/jobs/63120

closed

removed To Be Tested label

added Fixed label