the link in the public form is wrong

Description

when creating a public form the link is wrong it contains the port number that should not be there

Distribution Name and Version

Debian

FusionDirectory Version

1.4-dev

Plugin with the defect

public form

PHP version used

php 7.0x

Origin of php packages

FusionDirectory

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behavior:

the port should not be inside the link

Actual behavior:

the port is always in the link

Reproduces how often:

100%

Additional Information

see attached screenshot

changed due date to August 11, 2020

changed milestone to %FusionDirectory 1.4

added Bugs plugin-public-forms labels

Related code is here: https://gitlab.fusiondirectory.org/fusiondirectory/fd/-/blob/1.4-dev/include/class_URL.inc#L42

We’ll need to determine what is in those $_SERVER fields in your case to understand the problem. Maybe they are empty and the default value 80 is used, in which case the fix is easy (default to 443 for https).

@cchilliet,

there is not check for an empty server port and port should not be fixed to 80 by default, so if its empty its good and when not empty its added.

    } else {
      if (!empty($_SERVER['HTTP_HOST'])) {
        $host = $_SERVER['HTTP_HOST'];
      } else {
        $host = $_SERVER['SERVER_NAME'];
      }
      $port = $_SERVER['SERVER_PORT'];

Cheers

added 15m of time spent at 2020-08-06

removed Bugs label

removed due date

reopened

added PJ1802-0188 label

closed