update the system plugin

Descriptive title for this enhancement

update the system plugin to support the ipam plugin fonctionnality

Expected behavior

new behavior is described in https://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/wikis/FusiondirectoryIPAM#system-plugin

changed due date to April 07, 2020

changed milestone to %FusionDirectory 1.4

added enhancement plugin-systems labels

changed title from update the sysyem plugin to update the system plugin

mentioned in commit a12f0708

added PJ2002-0330 label

added 5h of time spent at 2020-04-08

mentioned in commit 5d55120b

added 3h of time spent at 2020-04-09

hello @MCMic,

we did a code / fonctionality / interface review of the system modification review here is our ideas.

• The code from ipam/admin/system/ipam should got to the system plugin to be the new code for managing interface on systems, its a great modernisation of our interface management and should not be restricted to ipam.

• the systems main tab should only show the properties of systems like show in the pictures below

• the system inteface creation should look like the picture below

The question remaining is for the subnet selection and vlan section should we only show them if the ipam plugin is installed and is it possible

added 30m of time spent at 2020-04-14

mentioned in commit c7a7de3f

mentioned in commit 1e1058bc

mentioned in commit dd6130dc

@bmortier Current code is crashing for system types which shows Mac and IP as single-value fields, currently this means mobile phones and network devices.

I’m not sure why those have single-value mac and ip, as I can see mobile phone having an IPv4 and an IPv6, at least.

But it also brings the question of whether it makes sense to show this new interfaces type for all system types, does it make sense to declare interfaces for phones and mobile phones?

[EDIT]Note: if we hide Mac and IP fields as you suggested, the single-value problem goes away, but maybe the single-value constraint should be added back to interfaces tab, and the question of whether this tab makes sense for all types remains

@MCMic i think interface should be generalized to all systems objects, on my android phone connected to wifi i have ipv4 and ipv6 adress, for the network devices it make sense to have interface also.

The system that make the ip mandatory or not from the config backend should still work