Skip to content
GitLab
Closed
Issue created by Jason Secula@jseculaReporter

Compatibility error between sudo and mixedgroup plugins

Closed

Compatibility error between sudo and mixedgroup plugins

Description

There is a compatibility error between sudo and mixedgroup plugin triggering an error when adding, deleting or editing a group with 2+ users in it already. The error only happens when sudo and mixedgroup plugins are installed altogether. Also it sometimes takes multiples retry to successfully edit the group once the error is showing up.

Distribution Name and Version

Ubuntu 18.04 bionic

FusionDirectory Version

1.3

Plugin with the defect

Sudo & Mixedgroup

PHP version used

7.2

Origin of php packages

Distribution packages

Steps to Reproduce

  1. Install both plugins and use rfc2307bis schema so you can use mixedgroup
  2. Create a group and add one user in it
  3. Try to add one more user to the group
  4. Try to delete the user from the group
  5. Try editing any data once they are at least two users in the group

Expected behavior:

The group being edited successfully without any errors since the users are valid.

Actual behavior:

An error is showing up blocking you from editing the group.

Reproduces how often:

everytime you try to edit a group with already 2+ members

Additional Information

Error showing up:

 Fatal error: Uncaught Error: Call to a member function hasChanged() on null in /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:1897 Stack trace: #0 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1632): simplePlugin->attributeHaveChanged('cn') #1 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1543): simplePlugin->browseForeignKeys('handle_move', NULL, NULL) #2 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1397): simplePlugin->handleForeignKeys() #3 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1350): simplePlugin->handle_post_events('modify') #4 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1232): simplePlugin->post_save() #5 /usr/share/fusiondirectory/plugins/admin/ogroups/mixedgroups/class_mixedGroup.inc(180): simplePlugin->save() #6 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(430): mixedGroup->save() #7 /usr/share/fusiondirectory/plugins/admin/groups/t in /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc on line 1897
Edited

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Activity

    • Jason Secula added Bugs label

      added Bugs label

    • Côme Chilliet assigned to @bmortier

      assigned to @bmortier

    • Jason Secula changed the description

      changed the description

    • bmortier added plugin-mixedgroups plugin-sudo labels

      added plugin-mixedgroups plugin-sudo labels

    • bmortier assigned to @jswaelens and unassigned @bmortier

      assigned to @jswaelens and unassigned @bmortier

    • bmortier changed due date to July 22, 2019

      changed due date to July 22, 2019

    • bmortier changed milestone to %FusionDirectory 1.4

      changed milestone to %FusionDirectory 1.4

    • Jonathan Swaelens
      Jonathan Swaelens @jswaelens ·
      Developer

      I reproduce on 1.4

      <div id="debug-handling" class="notice"><img src="geticon.php?context=status&amp;icon=dialog-information&amp;size=22" alt="Information" style="vertical-align:middle;margin-right:.2em;"/>There is some debug output <button onClick="javascript:$$('div.debug_div').each(function (a) { a.toggle(); });">Toggle</button></div><div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/management/class_management.inc:execute():446) - Action: <table style="border:none;" ><tr><td nowrap align="center" style="background-color:#1E32C8;color:white;;font:bold 8pt Verdana;" title="string[array]">targets</td><td nowrap="nowrap" style="background-color:#DDDDEE;font: 8pt Verdana; color:black;"><div style="color:blue;">Array (empty)</div></td></tr><tr><td nowrap align="center" style="background-color:#1E32C8;color:white;;font:bold 8pt Verdana;" title="string[string]">action</td><td nowrap="nowrap" style="background-color:#DDDDEE;font: 8pt Verdana; color:black;"><div style="color:black;" title="string">save</div></td></tr><tr><td nowrap align="center" style="background-color:#1E32C8;color:#FF9B2F;;font:bold 8pt Verdana;" title="string[NULL]">subaction</td><td nowrap="nowrap" style="background-color:#DDDDEE;font: 8pt Verdana; color:black;"><div style="color:black;" title="NULL"></div></td></tr></table></div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:save_object():227) - Saving: 'ogroup'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:save_object():1095) - save_object: 'cn=aaa,ou=groups,dc=nodomain'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:check():348) - Checking: 'ogroup'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:check():1511) - check: 'cn=aaa,ou=groups,dc=nodomain'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:check():348) - Checking: 'mixedGroup'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:check():1511) - check: 'cn=aaa,ou=groups,dc=nodomain'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:check():348) - Checking: 'reference'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:check():348) - Checking: 'ldapDump'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:save():383) - Saving: 'cn=aaa,ou=groups,dc=nodomain'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:save():412) - Saving: 'ogroup'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:save():1213) - save: 'cn=aaa,ou=groups,dc=nodomain'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc:save():412) - Saving: 'mixedGroup'</div>
<div class="debug_div">DEBUG[1] (/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:save():1213) - save: 'cn=aaa,ou=groups,dc=nodomain'</div>
<br />
<b>Fatal error</b>:  Uncaught Error: Call to a member function hasChanged() on null in /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc:1914
Stack trace:
#0 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1647): simplePlugin-&gt;attributeHaveChanged('cn')
#1 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1558): simplePlugin-&gt;browseForeignKeys('handle_move', NULL, NULL)
#2 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1407): simplePlugin-&gt;handleForeignKeys()
#3 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1360): simplePlugin-&gt;handle_post_events('modify', Array)
#4 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1242): simplePlugin-&gt;post_save()
#5 /usr/share/fusiondirectory/plugins/admin/ogroups/mixedgroups/class_mixedGroup.inc(179): simplePlugin-&gt;save()
#6 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(417): mixedGroup-&gt;save()
#7 /usr/share/fusiondirectory/plugins/admin/g in <b>/usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc</b> on line <b>1914</b><br />
    • Jonathan Swaelens added 20m of time spent at 2019-07-25

      added 20m of time spent at 2019-07-25

    • Jonathan Swaelens assigned to @MCMic and unassigned @jswaelens

      assigned to @MCMic and unassigned @jswaelens

    • Côme Chilliet mentioned in commit 9401c100

      mentioned in commit 9401c100

    • Jonathan Swaelens
      Jonathan Swaelens @jswaelens ·
      Developer

      Maybe not related but when modifying an old posix account after installing mixedgroup/sudo and upgrade my VM I had this crash

      <br />
<b>Fatal error</b>:  Uncaught TypeError: Argument 2 passed to array_differs() must be of the type array, null given, called in /usr/share/fusiondirectory/plugins/personal/posix/class_posixAccount.inc on line 575 and defined in /usr/share/fusiondirectory/include/functions.inc:1468
Stack trace:
#0 /usr/share/fusiondirectory/plugins/personal/posix/class_posixAccount.inc(575): array_differs(Array, NULL)
#1 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1227): posixAccount-&gt;shouldSave()
#2 /usr/share/fusiondirectory/plugins/personal/posix/class_posixAccount.inc(583): simplePlugin-&gt;save()
#3 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(417): posixAccount-&gt;save()
#4 /usr/share/fusiondirectory/include/management/class_management.inc(867): simpleTabs-&gt;save()
#5 /usr/share/fusiondirectory/include/management/actions/class_Action.inc(170): management-&gt;saveChanges(Array)
#6 /usr/share/fusiondirectory/include/management/class_management.inc(409): Action-&gt;execute(Object(userManagement), Array)
#7  in <b>/usr/share/fusiondirectory/include/functions.inc</b> on line <b>1468</b><br />
    • Côme Chilliet mentioned in commit f15527cd

      mentioned in commit f15527cd

    • Côme Chilliet
      Côme Chilliet @cchilliet ·
      Reporter

      Should be good

    • Côme Chilliet added 30m of time spent at 2019-07-29

      added 30m of time spent at 2019-07-29

    • Côme Chilliet added To Be Tested + 1 deleted label

      added To Be Tested + 1 deleted label

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply