When importing OPSI hosts, have an option to import the packages associated

Requirements

• Filling out the template is required. Any Enhancement request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions

Descriptive title for this enhancement

When importing an opsi object from the opsi import we need to import the packages associated to this opsi object and add it the the localboot list in the fusiondirectory opsi tab

Actual behavior

The packages are not imported

Expected behavior

the import of an opsi object with the opsi import should also import all the packages installed on this object

Step by step description of new behaviour

1. Import an object with the opsi import
2. Go to the fd system created by this import
3. the opsi tab localboot list should contains the list of packages

Benefits

Be able to import a opsi object completely with all his packages and their properties

Possible Drawbacks

None seen

Applicable Issues

import opsi object in full to fusiondirectory

This will only import localboots as netboot is not available outside of profiles. Should this be optionnal? How should it behave if a template is used which already adds an OPSI tab with profile and/or localboots?

if a template is used, the template should be used and localboot from opsi should not be used.

Maybe we should have a new opsi tab called original opsi system that is read only that show what was on the original opsi client when imported.

if there is no template used when should only import the localboot and add to the tab called original opsi system the localboot and netboot used

Still to be refined

added technical discussion label

created branch 5764-when-importing-an-opsi-object-from-the-opsi-import-we-need-to-import-the-packages-associated-to-this-opsi-object

mentioned in commit 4a8da25c

changed milestone to %FusionDirectory 1.3

added 2h of time spent at 2018-01-24

mentioned in issue argonaut/argonaut#5711

added To Be Tested label

created branch 5764-when-importing-an-opsi-object-from-the-opsi-import-we-need-to-import-the-packages-associated-to-this-opsi-object

mentioned in commit 02e9f5a5

added 30m of time spent at 2018-01-25

I have the following error when I try to import without ticking localboot

 Fatal error: Uncaught Error: Using $this when not in object context in /usr/share/fusiondirectory/plugins/admin/systems/class_systemImport.inc:152 Stack trace: #0 /usr/share/fusiondirectory/plugins/admin/systems/class_systemImport.inc(252): systemImport::massImport(Array, 'workstation', '', 'dc=antwerpen,dc...') #1 /usr/share/fusiondirectory/include/simpleplugin/class_dialogAttributes.inc(622): systemImport->handle_import() #2 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1101): ButtonAttribute->applyPostValue() #3 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(228): simplePlugin->save_object() #4 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1982): simpleTabs->save_object() #5 /usr/share/fusiondirectory/plugins/addons/opsi/main.inc(22): simplePlugin::mainInc('opsiImport', 'new', false, false) #6 /usr/share/fusiondirectory/html/main.php(286): require('/usr/share/fusi...') #7 {main} thrown in /usr/share/fusiondirectory/plugins/admin/systems/class_systemImport.inc on line 152

removed To Be Tested label

added To Be Tested label

When I try to import localboot I have the following php error

PHP error "Undefined index: fqdn" - File: /usr/share/fusiondirectory/plugins/addons/opsi/class_opsiImport.inc (Line 136)

removed To Be Tested label

After correcter the php error and update argonaut I have the following error.

added 5m of time spent at 2018-01-25