Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory-plugins fusiondirectory-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectory-pluginsfusiondirectory-plugins
  • Issues
  • #5471
Something went wrong while setting issue due date.
Closed
Open
Issue created 8 years ago by jbecot@jbecotReporter
  • New related issue

  • New related issue

DHCP configuration enhancement

Closed

DHCP configuration enhancement

Hello,

I know you're working on the buggy folding menus on the dhcp object page, but there is to issues on the subnet edition page :

  • the range box is commented with "included starting and ending address separated with a dash" but dhcp 4.2.5 on redhat expects a space separation. Either it is not the standard and it would be nice to fix this comment or it is and it would be more appropriate to have to input boxes for start ip and end ip (so we do not bother the space)
  • the comments are expected surronded with double quotes and it's weird to sourround the comment in a comment box. Maybe a check in the code would be nice.

(from redmine: issue id 5471, created on 2017-04-06, closed on 2017-04-24)

  • Changesets:
    • Revision 3afb6434 by Côme Chilliet on 2017-04-18T09:31:09.000Z:
Fixes #5471 DHCP ranges should be separated by spaces (schema description was wrong)
  • Custom Fields:
    • Bug in version: 1.0.20
    • Support contract: None
    • Dolibarr project Name: PJ1610-0019
An error occurred while loading designs. Please try again.

Tasks

0
Cannot read properties of undefined (reading 'workItem')

Linked items
0

Link issues together to show that they're related. Learn more.

Activity


  • Côme Chilliet
    Côme Chilliet @cchilliet · 8 years ago
    Reporter

    Jerome BECOT wrote:

    • the range box is commented with "included starting and ending address separated with a dash" but dhcp 4.2.5 on redhat expects a space separation. Either it is not the standard and it would be nice to fix this comment or it is and it would be more appropriate to have to input boxes for start ip and end ip (so we do not bother the space)

    The comment for this attribute comes from the official schema so I expect it to be correct: https://source.isc.org/cgi-bin/gitweb.cgi?p=dhcp.git;a=blob;f=contrib/ldap/dhcp.schema;hb=HEAD It’s complicated to put two fields because it can be only one IP as explained in the comment.

    • the comments are expected surrounded with double quotes and it's weird to surround the comment in a comment box. Maybe a check in the code would be nice.

    Are you sure they need to be quoted? The description in the attribute says nothing about this, and examples I’ve seen on the web were without quotes.

    (from redmine: written on 2017-04-12)

  • Côme Chilliet
    Côme Chilliet @cchilliet · 8 years ago
    Reporter

    Applied in changeset commit:fusiondirectory-plugins|3afb6434.

    (from redmine: written on 2017-04-18)

  • Côme Chilliet
    Côme Chilliet @cchilliet · 8 years ago
    Reporter

    Indeed the official schema description seems false, the examples uses spaces and not hyphens and the code seems to expect spaces. I fixed the description in our schema & UI and I added a pattern to the attribute to enforce the use of a space. I emailed the ISC project regarding this issue and I hope that they will fix the schema description.

    Regarding comments I did not find anything conclusive saying they would need quotes. The code does not seem to read comments at all.

    (from redmine: written on 2017-04-18)

  • Jonathan Swaelens
    Jonathan Swaelens @jswaelens · 8 years ago
    Developer

    Close issue

    (from redmine: written on 2017-04-24)

  • Côme Chilliet
    Côme Chilliet @cchilliet · 7 years ago
    Reporter

    Set time spent

    (from redmine: written on 2017-06-22)

  • Jonathan Swaelens closed 7 years ago

    closed

  • Côme Chilliet added 1h 30m of time spent 7 years ago

    added 1h 30m of time spent

  • bmortier added Fixed label 6 years ago

    added Fixed label

Please register or sign in to reply
Assignee
Côme Chilliet's avatar
Côme Chilliet
Assign to
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
Due date
None
None
None
Time tracking
No estimate or time spent
Confidentiality
Not confidential
Not confidential

You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

Lock issue
Unlocked
0
0 Participants
Reference:

Menu

Explore Projects Groups Topics Snippets