Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory-plugins fusiondirectory-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectory-pluginsfusiondirectory-plugins
  • Issues
  • #4888
Something went wrong while setting issue due date.
Closed
Open
Issue created 8 years ago by bmortier@bmortierMaintainer
  • New related issue

  • New related issue

DNS record matching should be case insensitive

Closed

DNS record matching should be case insensitive

Hello,

one user asked for having uppercase domaine name in the dns plugin.

Not sure its a good idea but we should look what the rfc and bind say on this matter

(from redmine: issue id 4888, created on 2016-06-16, closed on 2016-11-24)

  • Relations:
    • copied_to #4884 (closed)
  • Changesets:
    • Revision 630beb81 by Côme Chilliet on 2016-09-14T09:30:36.000Z:
Fixes #4888 DNS record matching should be case insensitive
  • Revision b5dca3a5 by Côme Chilliet on 2016-11-18T16:11:13.000Z:
Fixes #4888 DNS record matching should be case insensitive
  • Custom Fields:
    • Bug in version: 1.0.13

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Linked items
    0

    Link issues together to show that they're related. Learn more.

    Activity


    • gargamel
      gargamel @gargamel · 8 years ago
      Reporter

      So as requested.

      " Note that while upper and lower case letters are allowed in domain names, no significance is attached to the case. That is, two names with the same spelling but different case are to be treated as if identical. " from: [[https://tools.ietf.org/html/rfc1035]]

      So yes the patch "could" be applied. But the RFC say that Google.com and GOOGLE.com and google.com are the same, so why only accept google.com? (yes, i know.. because the patch is simple :-p)

      But that don't remove the other bug, in the system plugins/dns record (first screenshot). Or you need to adapt this patch for the system plugins too, to not accept lowercase for workstation/server/etc...

      But: [[https://deepthought.isc.org/article/AA-01113/0/Case-Insensitive-Response-Compression-May-Cause-Problems-With-Mixed-Case-Data-and-Non-Conforming-Clients.html]]

      And the RFC1034 say: [[https://www.ietf.org/rfc/rfc1034.txt]]

      " By convention, domain names can be stored with arbitrary case, but domain name comparisons for all present domain functions are done in a case-insensitive manner, assuming an ASCII character set, and a high order zero bit. This means that you are free to create a node with label "A" or a node with label "a", but not both as brothers; you could refer to either using "a" or "A". When you receive a domain name or label, you should preserve its case. "

      Regards.

      (from redmine: written on 2016-06-17)

    • Côme Chilliet
      Côme Chilliet @cchilliet · 8 years ago
      Reporter

      Renamed the bug, for me we just need to fix the DNS tab code so that it finds the records even if the machine cn is not lowercase, this seems quite easy to fix. I think it’s better to only allow lowercase on DNS side.

      (from redmine: written on 2016-07-11)

    • bmortier
      bmortier @bmortier · 8 years ago
      Author Maintainer

      Close issue

      (from redmine: written on 2016-11-24)

    • bmortier closed 7 years ago

      closed

    • bmortier added Fixed label 6 years ago

      added Fixed label

    Please register or sign in to reply
    Assignee
    Côme Chilliet's avatar
    Côme Chilliet
    Assign to
    Labels
    0
    None
    0
    None
      Assign labels
    • Manage project labels

    Milestone
    No milestone
    None
    Due date
    None
    None
    None
    Time tracking
    No estimate or time spent
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

    Lock issue
    Unlocked
    0
    0 Participants
    Reference:

    Menu

    Explore Projects Groups Topics Snippets