Can't edit system: "Workstation"

Howto: Since 1.0.13

Create a Workstation -> apply -> then edit and have a beautiful:

Fatal error: Uncaught exception 'NonExistingLdapNodeException' with message 'Could not open dn cn=test,ou=printers,ou=systems,dc=fusiondirectory,dc=org' in /usr/share/fusiondirectory/include/class_plugin.inc:168 Stack trace: #0 /usr/share/fusiondirectory/plugins/admin/systems/class_printGeneric.inc(103): plugin->__construct('cn=test,ou=prin...') #1 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(108): printgeneric->__construct('cn=test,ou=work...', Object(workstationGeneric), Object(simpleTabs), false) #2 /usr/share/fusiondirectory/include/class_management.inc(756): simpleTabs->__construct(NULL, Array, 'cn=test,ou=work...', 'workstation') #3 /usr/share/fusiondirectory/plugins/admin/systems/class_systemManagement.inc(337): management->editEntry('edit', Array, Array, 'simpleTabs', 'WORKSTATIONTABS', 'workstation') #4 /usr/share/fusiondirectory/include/class_management.inc(455): systemManagement->editEntry('edit', Array, Array) #5 /usr/share/fusiondirectory/include/class_management.inc(172): management-> in /usr/share/fusiondirectory/include/class_plugin.inc on line 168

(from redmine: issue id 4876, created on 2016-06-13, closed on 2016-06-14)

• Changesets:
  • Revision bfc829d0 by Benoit MORTIER on 2016-06-14T00:55:55.000Z:

Fixes: #4876 Can't edit system: "Workstation"

Signed-off-by: Mortier Benoit <benoit.mortier@opensides.be>

• Custom Fields:
  • Bug in version: 1.0.12

hello,

i found the source of this, you can comment in class_printGeneric.inc

/* Update dn, to ensure storing as printer instead of WS / terminal */
if (preg_match("/Terminal/i", $this->BelongsTo) || preg_match("/TerminalTemplate/i", $this->BelongsTo)) {
  $this->dn = preg_replace("/".preg_quote(get_ou('terminalRDN'), '/')."/i", get_ou('printerRDN'), $this->dn);
}

if (preg_match("/Workstation/i", $this->BelongsTo) || preg_match("/WorkstationTemplate/i", $this->BelongsTo)) {
  $this->dn = preg_replace("/".preg_quote(get_ou('workstationRDN'), '/')."/i", get_ou('printerRDN'), $this->dn);
}

and workstations and terminal will save and open correctly

(from redmine: written on 2016-06-14)

hello,

fix pushed into 1.0.13-fixes

Cheers

(from redmine: written on 2016-06-14)

Hello,

I commented the lines and it's works.

With this bug fix, now we can't add printer. got this error:

Fatal error: Call to a member function getBaseObject() on null in /usr/share/fusiondirectory/plugins/admin/systems/class_printGeneric.inc on line 414

(from redmine: written on 2016-06-14)

hello,

thank you

Closing it

Close issue

(from redmine: written on 2016-06-14)

closed

added Fixed label