ppolicy: user interface improvements

Hi!

Please implement improvements on the ppolicy tab:

• print the "Account locked time" like the "Last password change" field: formatted output and set local timezone.
• the attribute pwdReset: TRUE can be used to force password change on next login even if the account was not locked before. Please add a checkbox, e.g. "Force password change on next login".
• the current status of the forced password change setting should be reflected in this checkbox when a user is edited.

Thanks!

Christian

(from redmine: issue id 4743, created on 2016-04-21, closed on 2016-04-29)

• Relations:
  • relates #4556 (closed)
• Changesets:
  • Revision a3e75ae2 by Côme Chilliet on 2016-04-22T03:21:32.000Z:

Fixes #4743 Added parsing of ppolicy account locked time

• Revision 8c2fece1 by Côme Chilliet on 2016-04-22T03:22:19.000Z:

Fixes #4743 Added parsing of ppolicy account locked time

• Revision d3b21419 by Côme Chilliet on 2016-04-26T02:01:54.000Z:

Fixes #4743 Changed pwdReset labels and behavior

• Revision f5fc0299 by Côme Chilliet on 2016-04-26T02:04:25.000Z:

Fixes #4743 Changed pwdReset labels and behavior

• Uploads:
  • class_ppolicyAccount.inc.patch

Hello,

The pwdReset field already appears as «Reset locking». «Reset with the same password» sets it to FALSE and «Reset and force change» sets it to TRUE. Indeed the current state of the attribute is not shown, if I recall correctly it was because when I tested it seemed to not work, if I set it to TRUE it would stay TRUE forever, maybe I did not understand how this attribute is supposed to work. Maybe you can remove the line «$this->pwdReset = '';» (line 93) in the file fusiondirectory/plugins/personal/ppolicy/class_ppolicyAccount.inc and see if it works as you want. About using this pwdReset when the account is not locked, maybe changing the name of the field and its options would be enough? Do you have any ideas regards such changes?

About "Account locked time", could you check if what I pushed is working? You can just take this version of the file and try it on your instance: https://git.fusiondirectory.org/gitweb/?p=main/fusiondirectory-plugins.git;a=blob_plain;f=ppolicy/personal/ppolicy/class_ppolicyAccount.inc;h=8af46e9ea4ba86209143a3e312d3d99d1cd34c1e;hb=refs/heads/1.0.11-fixes

(from redmine: written on 2016-04-22)

Hi!

The "Account locked time" is formatted correctly when using the new file. Thanks!

pwdReset attribute is removed when a password change occurs.

Attached is a patch against your changes adding a new DisplayAttribute showing the status of forced password reset. I've also changed the "Reset locking" select menu to make it more clear, that it can be used not only to unlock an account but also to force a password reset. Please test these changes, as the changed strings did not show up, but the logic was working. Maybe some updates to the translation required.

Thanks!

Christian

(from redmine: written on 2016-04-22)

Hum, the problem is that even with your patch pwdReset will be removed if the tab is saved without changing anything because of the «$this->pwdReset = ''» line. I’d feel more comfortable if we could keep only the pwdReset field as a SelectAttribute. I’m not sure a SelectAttribute can behave correctly with two identical choices values.

What do you think of: Attribute label: «Reset locking/force change» or «Reset locking or force change» or «Force change or reset locking» Values: «», «Force change (resets locking)», «Reset only (same password)»

And we do not empty pwdReset, so the selected value will keep appearing selected until a password change is done or it’s changed manually.

(from redmine: written on 2016-04-25)

Hi!

Ok, let's keep the simple and save approach and only change the strings and display the current value as SelectAttribute. I'm fine with any of your attribute labels. The values are more descriptive now.

Thanks!

Christian

(from redmine: written on 2016-04-25)

It’s pushed, please test it to be sure. Check that setting pwdReset works, and that not modifying it does not cause problems.

There’s this in the code:

    if (!empty($this->pwdReset)) {
      $this->attrs['pwdAccountLockedTime'] = array();
    } else {
      unset($this->attrs['pwdAccountLockedTime']);
    }

Which removes pwdAccountLockedTime when pwdReset is set, is that the correct thing to do? (the = array() means remove it, the unset means do not modify it)

(from redmine: written on 2016-04-26)

Seems good for me

Close issue

(from redmine: written on 2016-04-29)

closed

added Added label