Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory-plugins fusiondirectory-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectory-pluginsfusiondirectory-plugins
  • Issues
  • #4456
Something went wrong while setting issue due date.
Closed
Open
Issue created 9 years ago by rtp@rtpReporter
  • New related issue

  • New related issue

Can't find a way to specify a '/' in distribution or media name in the repository plugin

Closed

Can't find a way to specify a '/' in distribution or media name in the repository plugin

For some cases, specifying a '/' is needed.

Eg:

  • Mageia: media core/release

  • Debian: wheezy/updates

It's not possible atm (see screenshot) but using a '/' directly is a bad idea anyway, as it's used by plugin. For instance: fdRepoDistributionSection: rtp.jessie/main fdRepoDistributionSection: rtp.sid/main fdRepoDistributionSection: rtp.wheezy/main fdRepoDistributionSection: rtp.wheezy-backports/main fdRepoDistributionSection: rtp.jessie-backports/main

I was using '-' previously but it can't work as there are also wheezy-updates distribution out there (in volatile).

Would be nice to find a new character to 'replace' the '/' but I was unable to find a character accepted by the plugin.

(from redmine: issue id 4456, created on 2016-01-12, closed on 2016-01-27)

  • Changesets:
    • Revision 26f6b8d6 by Côme Chilliet on 2016-01-19T10:57:20.000Z:
Fixes #4456 Switching to | as a distribution-section separator as they can contain slashes
  • Revision 0781a9e5 by Côme Chilliet on 2016-01-20T09:06:58.000Z:
Fixes #4456 Switching to | as a distribution-section separator as they can contain slashes
  • Revision f3adf389 by Côme Chilliet on 2016-01-20T09:16:27.000Z:
Fixes #4456 Switching to | as a distribution-section separator as they can contain slashes
  • Custom Fields:
    • Bug in version: 1.0.9.2
  • Uploads:
    • fd-repo-invalid-char

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Linked items
    0

    Link issues together to show that they're related. Learn more.

    Activity


    • Côme Chilliet
      Côme Chilliet @cchilliet · 9 years ago
      Reporter

      / could be accepted in section names and not in distribution name? We would still use / so it would be debian/wheezy/updates, and the tools would only cut at the first /. What do you think?

      (from redmine: written on 2016-01-12)

    • rtp
      rtp @rtp · 9 years ago
      Author Reporter

      Côme BERNIGAUD wrote:

      / could be accepted in section names and not in distribution name?

      No, it's not but I was using '-' to workaround it. Unfortunately, found out it was a bad idea when I got the same issue with the distribution.

      We would still use / so it would be debian/wheezy/updates, and the tools would only cut at the first /. What do you think?

      If the tool can cope with that and allows us to use '/', I'm fine with it

      (from redmine: written on 2016-01-12)

    • Côme Chilliet
      Côme Chilliet @cchilliet · 9 years ago
      Reporter

      Arnaud Patard wrote:

      Côme BERNIGAUD wrote:

      / could be accepted in section names and not in distribution name?

      No, it's not but I was using '-' to workaround it. Unfortunately, found out it was a bad idea when I got the same issue with the distribution.

      I meant I get that / could be used in section names, but do you need to use it in distribution names? The solution I talked about only works for / in section names, not in distribution names.

      (from redmine: written on 2016-01-18)

    • rtp
      rtp @rtp · 9 years ago
      Author Reporter

      Côme BERNIGAUD wrote:

      I meant I get that / could be used in section names, but do you need to use it in distribution names? The solution I talked about only works for / in section names, not in distribution names.

      Yeah, I need it in the distribution names. To take the example I gave previously. For the updates for jessie, the apt configuration looks like:

      deb http://security.debian.org/ jessie/updates main
      deb http://ftp.fr.debian.org/debian/ jessie-updates main
      

      This means that the suite names are "jessie/updates" and "jessie-updates". Of course, this also mean that using '-' to specify '/' won't work as it'll break 'jessie-updates'.

      (from redmine: written on 2016-01-18)

    • Côme Chilliet
      Côme Chilliet @cchilliet · 9 years ago
      Reporter

      Switching to '|' as a separator might be the best solution then? It’s already the used separator if the FAIrepository field of the FAI plugin.

      (from redmine: written on 2016-01-19)

    • Côme Chilliet
      Côme Chilliet @cchilliet · 9 years ago
      Reporter

      Côme BERNIGAUD wrote:

      Switching to '|' as a separator might be the best solution then? It’s already the used separator if the FAIrepository field of the FAI plugin.

      This solution is now pushed to 1.0.9.2-fixes, 1.0.10 and 1.1

      (from redmine: written on 2016-01-20)

    • Jonathan Swaelens
      Jonathan Swaelens @jswaelens · 9 years ago
      Developer

      The section is well created (with a '/' in the name) but when I try to open it I have an error.

      Fatal error: Uncaught exception 'NonExistingObjectTypeException' with message 'Non-existing type ""' in /usr/share/fusiondirectory/include/class_objects.inc:214 Stack trace: #0 /usr/share/fusiondirectory/include/class_objects.inc(151): objects::infos(NULL) #1 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(598): objects::open('cn=rtp.jessie\x01S...', NULL) #2 /usr/share/fusiondirectory/include/class_management.inc(461): simpleManagement->editEntry('edit', Array, Array) #3 /usr/share/fusiondirectory/include/class_management.inc(175): management->handleActions(Array) #4 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(901): management->execute() #5 /usr/share/fusiondirectory/plugins/admin/repository/main.inc(21): simpleManagement::mainInc('repositoryManag...') #6 /usr/share/fusiondirectory/html/main.php(283): require('/usr/share/fusi...') #7 {main} thrown in /usr/share/fusiondirectory/include/class_objects.inc on line 214
      

      (from redmine: written on 2016-01-22)

    • bmortier
      bmortier @bmortier · 9 years ago
      Maintainer

      hello,

      i just tested the fix and it ssems to save right the first time but trigger an error if i reopen and save

      Move from "cn=wheezySLupdates,ou=repository,dc=fusiondirectory,dc=org" to "cn=wheezy/updates,ou=repository,dc=fusiondirectory,dc=org" failed

      here is my entry

      59 cn=main,ou=repository,dc=fusiondirectory,dc=org objectClass: fdBuildRepositorySection cn: main

      60 cn=contrib,ou=repository,dc=fusiondirectory,dc=org objectClass: fdBuildRepositorySection cn: contrib

      61 cn=non-free,ou=repository,dc=fusiondirectory,dc=org objectClass: fdBuildRepositorySection cn: non-free

      62 cn=wheezy/updates,ou=repository,dc=fusiondirectory,dc=org objectClass: fdBuildRepositoryDistribution cn: wheezy/updates fdRepoSection: main fdRepoSection: contrib fdRepoSection: non-free

      (from redmine: written on 2016-01-27)

    • bmortier
      bmortier @bmortier · 9 years ago
      Maintainer

      hello,

      i works correctly now, closing it

      Cheers

      Close issue

      (from redmine: written on 2016-01-27)

    • bmortier closed 7 years ago

      closed

    • bmortier added Changed label 6 years ago

      added Changed label

    Please register or sign in to reply
    Assignee
    Côme Chilliet's avatar
    Côme Chilliet
    Assign to
    Labels
    0
    None
    0
    None
      Assign labels
    • Manage project labels

    Milestone
    No milestone
    None
    Due date
    None
    None
    None
    Time tracking
    No estimate or time spent
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

    Lock issue
    Unlocked
    0
    0 Participants
    Reference:

    Menu

    Explore Projects Groups Topics Snippets