fix(public-forms) Minor fixes

A sonar fix and a button name change

issue #5838

public-forms/ihtml/themes/breezy/public-form.tpl

@@ -24,7 +24,7 @@
           </div>
         </div>
         <div id="window-footer" class="plugbottom">
-          <input type="submit" name="template_continue" value="{t}Continue{/t}"/>
+          <input type="submit" name="form_submit" value="{msgPool type=okButton}"/>
         </div>
       </form>
     </div>

public-forms/include/class_publicFormPage.inc

@@ -38,13 +38,13 @@ class publicFormPage extends standAlonePage
 
     if (!isset($this->form) && isset($_GET['form'])) {
       /* Search for the form object */
-      $form = objects::ls('publicForm', array('dn' => 'raw', 'cn' => 1, 'fdPublicFormTitle' => 1, 'fdPublicFormText' => 1, 'fdPublicFormTemplateType' => 1, 'fdPublicFormTemplateDN' => 1), NULL, '(cn='.ldap_escape_f($_GET['form']).')');
-      if (count($form) <= 0) {
+      $forms = objects::ls('publicForm', array('dn' => 'raw', 'cn' => 1, 'fdPublicFormTitle' => 1, 'fdPublicFormText' => 1, 'fdPublicFormTemplateType' => 1, 'fdPublicFormTemplateDN' => 1), NULL, '(cn='.ldap_escape_f($_GET['form']).')');
+      if (count($forms) <= 0) {
         throw new FusionDirectoryException('Form "'.$_GET['form'].'" could not be found');
-      } elseif (count($form) > 1) {
+      } elseif (count($forms) > 1) {
         throw new FusionDirectoryException('Several forms match the name "'.$_GET['form'].'"');
       }
-      $this->form     = reset($form);
+      $this->form     = reset($forms);
       $this->template = new template($this->form['fdPublicFormTemplateType'], $this->form['fdPublicFormTemplateDN']);
     } elseif (!isset($this->form)) {
       throw new FusionDirectoryException('No form name given');

[Ghost User]

SonarQube analysis reported 4 issues

• 3 major
• 1 info

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

1. Remove this commented out code.
2. Remove this commented out code.
3. Remove this commented out code.
4. Complete the task associated to this "TODO" comment.