fix(public-forms) Some tests using new core functions

issue #5838

public-forms/html/publicform.php

@@ -22,6 +22,4 @@ require_once('../include/php_setup.inc');
 require_once('functions.inc');
 require_once('variables.inc');
 
-$publicPage = new publicFormPage();
-
-$publicPage->execute();
+publicFormPage::run();

public-forms/ihtml/themes/breezy/public-form.tpl

@@ -38,6 +38,7 @@
           </div>
         </div>
         {/if}
+        <input type="hidden" name="CSRFtoken" value="{$CSRFtoken}"/>
       </form>
     </div>
   </div>

public-forms/include/class_publicFormPage.inc

@@ -64,6 +64,12 @@ class publicFormPage extends standAlonePage
       }
       $this->form     = reset($forms);
       $this->template = new template($this->form['fdPublicFormTemplateType'], $this->form['fdPublicFormTemplateDN']);
+      /* TODO this is only for POC */
+      $this->template->alterAttributes(
+        ['user' => ['telephoneNumber']],
+        ['user' => ['mobile']],
+        ['user' => ['base']]
+      );
     } elseif (!isset($this->form)) {
       throw new FusionDirectoryException('No form name given');
     }
@@ -98,7 +104,8 @@ class publicFormPage extends standAlonePage
       $templateOutput = $this->template->execute();
       if ($this->template->dialogOpened()) {
         //~ TODO
-        return $templateOutput;
+        $smarty->assign('template_dialog', $templateOutput);
+        //~ return $templateOutput;
       } else {
         $smarty->assign('template_dialog', $templateOutput);
       }

[Ghost User]

Complete the task associated to this "TODO" comment.

[Ghost User]

Remove this commented out code.

[Ghost User]

SonarQube analysis reported 4 issues

• 2 major
• 2 info

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

1. Remove this conditional structure or edit its code blocks so that they're not all the same.
2. Complete the task associated to this "TODO" comment.