fusiondirectory issueshttps://gitlab.fusiondirectory.org/groups/fusiondirectory/-/issues2022-09-01T10:07:21Zhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6113Add tar.gz build for fixes branch2022-09-01T10:07:21ZbmortierAdd tar.gz build for fixes branch## Descriptive title for this enhancement
Add tar.gz build for fixes branch
### Actual behavior
We only build dev branch
### Expected behavior
Build fixes branches too
### Benefits
Automaticaly build fixes packages after merge## Descriptive title for this enhancement
Add tar.gz build for fixes branch
### Actual behavior
We only build dev branch
### Expected behavior
Build fixes branches too
### Benefits
Automaticaly build fixes packages after mergeFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6112change the donate part to add all the crowfunding possibilities2022-09-01T09:27:38Zbmortierchange the donate part to add all the crowfunding possibilitieshello,
we need to replace the donate with all our crowfunding possibilities
Cheershello,
we need to replace the donate with all our crowfunding possibilities
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6111add the badge for https://bestpractices.coreinfrastructure.org2022-09-09T08:24:35Zbmortieradd the badge for https://bestpractices.coreinfrastructure.orghello,
we need to add the markdown for the best practice badge https://bestpractices.coreinfrastructure.org/en/projects/351
cheershello,
we need to add the markdown for the best practice badge https://bestpractices.coreinfrastructure.org/en/projects/351
cheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6103Unable to change template name or create template2022-09-01T08:11:45ZbmortierUnable to change template name or create template### Description
After given the correct (I'm guessing) ACL to person to modify user templates, those person can modify indeed all template. But the user cannot modify the name of the template (that's minor bug). They are no error messag...### Description
After given the correct (I'm guessing) ACL to person to modify user templates, those person can modify indeed all template. But the user cannot modify the name of the template (that's minor bug). They are no error message, if the person change the name, he can save. But nothing actually change. The name still the old one.
More inconvenient the person cannot create a a template, He got the menu to create a template, he is invited in the tab to create a template, and what ever you name the template, FD say thay are a conflict with some other tempate whos name a nothing to do with the name the person choose, it's even not in the same branch.
Don't know where the problem are. Maybe in the ACL because as super_admin everything work. But because the person can modify anything in the model...
### Distribution Name and Version
Debian 9.12
### FusionDirectory Version
1.3
### PHP version used
7.0.33
### Origin of php packages
Distribution packages
### Steps to Reproduce
1. Select a modele
2. Change the name
3. Save the template
4. Check the name
1. Select Action/Add/Model
2. Enter anything in the name
3. Save
**Expected behavior:**
The name are change.
The template are created
**Actual behavior:**
The name still the same/
Got some strange error about conflict name
**Reproduces how often:**
100%FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6097Smarty path is not set correctly by fusiondirectory-setup --write-vars2020-10-19T12:55:15ZbmortierSmarty path is not set correctly by fusiondirectory-setup --write-vars### Description
When using fusiondirectory-setup with --write-vars, SMARTY value isn't correctly set
### Distribution Name and Version
Debian 10
### FusionDirectory Version
1.4 dev from GIT
### PHP version used
PHP7.3
### Origin of...### Description
When using fusiondirectory-setup with --write-vars, SMARTY value isn't correctly set
### Distribution Name and Version
Debian 10
### FusionDirectory Version
1.4 dev from GIT
### PHP version used
PHP7.3
### Origin of php packages
Debian
### Steps to Reproduce
1. root@fusion-dev:/var/www/html/fusiondirectory# git clone https://gitlab.fusiondirectory.org/fusiondirectory/fd.git
2. /usr/local/bin/fusiondirectory-setup --set-fd_home=/var/www/html/fusiondirectory/fd --yes --check-directories --update-cache --update-locales --write-vars
3. with git diff : I get :
```
-/*!
- * \brief Path for smarty3 libraries
- */
-define("SMARTY", "/usr/share/php/smarty3/Smarty.class.php");
+/* Path for smarty3 libraries */
+define("SMARTY", "/usr/share/php/smarty3");
```
Smarty.class.php is missing
**Reproduces how often:**
100%
### Additional Information
As Smarty isn't loaded, UI could be displayedFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6095put the fusiondirectory/.github/FUNDING.yml for github2023-06-23T20:02:21Zbmortierput the fusiondirectory/.github/FUNDING.yml for github## Descriptive title for this enhancement
<!-- required -->
github now allows to put sponsoring links to the repository for the various monetary contributing platforms
### Actual behavior
<!-- What actually happens -->
no link to ou...## Descriptive title for this enhancement
<!-- required -->
github now allows to put sponsoring links to the repository for the various monetary contributing platforms
### Actual behavior
<!-- What actually happens -->
no link to our donating platforms
### Expected behavior
<!-- What you expect to happen-->
be able to promote crowfunding platform
### Step by step description of new behaviour
we need to add a .github/FUNDING.yml
### Benefits
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
raise awardness of way of micro donating to fusiondirectory
### Possible Drawbacks
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->
none
### Applicable Issues
<!-- optional -->
<!-- Enter any applicable Issues here -->
crowfundingFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6038Move the "Click the 'Edit' button" message to the left2021-01-28T20:52:47ZbmortierMove the "Click the 'Edit' button" message to the left## Descriptive title for this enhancement
<!-- required -->
Move the "Click the 'Edit' button below to change information in this dialog" message to the left of the top header.
### Actual behavior
<!-- What actually happens -->
Lots o...## Descriptive title for this enhancement
<!-- required -->
Move the "Click the 'Edit' button below to change information in this dialog" message to the left of the top header.
### Actual behavior
<!-- What actually happens -->
Lots of people look but don't find the edit button at the bottom, especially on big screen, and told us that they have not hint where the edit button is.
### Expected behavior
<!-- What you expect to happen-->
Move the message to the left so its clearly read by users
### Benefits
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
More clarity for the users
### Possible Drawbacks
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->
NoneFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6030correct the get help section in the readme.md2022-09-08T13:12:24Zbmortiercorrect the get help section in the readme.mdhello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirectory-plugins/issues/22
cheershello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirectory-plugins/issues/22
cheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6024Cleanup session handling2021-01-03T12:45:52ZbmortierCleanup session handlingSome crash we had recently seems related to sessions ( #6003 #6023 ).
There is an unused channel system in FD which dates from GOsa and I think was added to attempt to split session vars by browser tab or something like that.
To avoid ...Some crash we had recently seems related to sessions ( #6003 #6023 ).
There is an unused channel system in FD which dates from GOsa and I think was added to attempt to split session vars by browser tab or something like that.
To avoid session problems and make problems easier to debug I suggest we:
1. Remove the channel system
2. Remove the global_ methods and use always use set/get instead
3. Remove the reference returning in session::get. Using a reference on a session var is a bad idea and is most likely the source of some of our problems
4. Remove all calls to session_ functions outside of our session class and make sure everything goes through it.FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6023Email icon missing from core2019-08-29T09:13:34ZbmortierEmail icon missing from coreSince https://gitlab.fusiondirectory.org/fusiondirectory/fd/issues/5840 fix, the recovery page Selenium test is almost always failing with a CSRF error.
It is quite hard to reproduce as it only happens on first try, and seems tightly re...Since https://gitlab.fusiondirectory.org/fusiondirectory/fd/issues/5840 fix, the recovery page Selenium test is almost always failing with a CSRF error.
It is quite hard to reproduce as it only happens on first try, and seems tightly related to the workflow used.
We should try to fix this one as some other CSRF protection related crash have been encountered and they may be related.
I should also note that any session problem, or manual URL tinkering may result in this kind of CSRF protection error.FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6086XSS in login screen2020-12-15T14:08:59ZbmortierXSS in login screenIt’s possible to inject code in login screen using message and plug GET parameters, and server POST parameters.It’s possible to inject code in login screen using message and plug GET parameters, and server POST parameters.FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6017IntAttribute badly handle empty value when minimum is set2020-10-19T13:59:47ZbmortierIntAttribute badly handle empty value when minimum is set### Description
When an IntAttribute as a minimum set greater than 0 and is not required, it should accept an empty value.
### FusionDirectory Version
<!-- Required -->
1.4
### PHP version used
<!-- Required -->
7
### Origin of php...### Description
When an IntAttribute as a minimum set greater than 0 and is not required, it should accept an empty value.
### FusionDirectory Version
<!-- Required -->
1.4
### PHP version used
<!-- Required -->
7
### Origin of php packages
<!-- Required -->
<!-- Distribution packages, Out of distribution -->
Debian
**Expected behavior:**
<!-- What you expect to happen-->
Accept empty value
**Actual behavior:**
<!-- What actually happens -->
Complains about invalid value
### Additional Information
<!-- optional -->
<!-- Any additional information, configuration or data that might be necessary to reproduce the issue. -->
Related to fd-plugins#5976FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6013update the UPDATE.md for 1.3.12019-07-05T09:29:18Zbmortierupdate the UPDATE.md for 1.3.1Hello,
we need to update the UPDATE.md or 1.3.1
CheersHello,
we need to update the UPDATE.md or 1.3.1
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6012update the manpages for 1.3.12019-07-04T13:12:16Zbmortierupdate the manpages for 1.3.1Hello,
we need to update the manpages for 1.3.1
CheersHello,
we need to update the manpages for 1.3.1
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6011Update the changelog for 1.3.12022-10-07T20:35:50ZbmortierUpdate the changelog for 1.3.1Hello,
we need to update the changelog for 1.3.1
CheersHello,
we need to update the changelog for 1.3.1
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6010increment version for fusiondirectory 1.3.12019-07-04T13:13:07Zbmortierincrement version for fusiondirectory 1.3.1hello,
we need to increment the version for fusiondirectory 1.3
Cheershello,
we need to increment the version for fusiondirectory 1.3
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6009updating the locales for 1.3.12022-09-09T08:44:22Zbmortierupdating the locales for 1.3.1Hello,
we need to update the locales for 1.3.1
CheersHello,
we need to update the locales for 1.3.1
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6007template error with use of placeholder for password expiration date2019-10-01T18:54:28Zbmortiertemplate error with use of placeholder for password expiration date### Description
generate date in template failed
### Distribution Name and Version
Centos7
### FusionDirectory Version
1.3.0
### PHP version used
php 7.1
### Origin of php packages
fusiondirectory
### Steps to Reproduce
<!-- R...### Description
generate date in template failed
### Distribution Name and Version
Centos7
### FusionDirectory Version
1.3.0
### PHP version used
php 7.1
### Origin of php packages
fusiondirectory
### Steps to Reproduce
<!-- Required -->
1. create a user template with placeholder %d[today+30days]|% in password expiration date
2. create de user with this account
3. date create is 27.01.1970
**Expected behavior:**
date value : 27.07.2019
**Actual behavior:**
date create is 27.01.1970
**Reproduces how often:**
100%
### Additional Information
debug info
Erreur PHP "A non well formed numeric value encountered" - Fichier: /usr/share/fusiondirectory/plugins/personal/posix/class_posixAccount.inc (Ligne 45)FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6006expiration date in dashboard is 02.01.19702020-01-10T14:46:16Zbmortierexpiration date in dashboard is 02.01.1970### Description
In dashboard -> Users, expiration date of expired accounts are the same value : 02.01.1970 but expiration date in accounts are ok (Users -> Accountname -> Unix -> password expiration date)
### Distribution Name and Ver...### Description
In dashboard -> Users, expiration date of expired accounts are the same value : 02.01.1970 but expiration date in accounts are ok (Users -> Accountname -> Unix -> password expiration date)
### Distribution Name and Version
Centos7
### FusionDirectory Version
1.3.0
### PHP version used
7.1
### Origin of php packages
fusion directory
### Steps to Reproduce
1. put an expiration date in Users -> Accountname -> Unix -> password expiration date
2. go to dashboard -> Users
3. expiration date are 02.01.1970
**Expected behavior:**
good expiration date
**Actual behavior:**
02.01.1970
**Reproduces how often:**
100%
### Additional Information
no problem with fusiondirectory 1.2.3
dashboard display good expired accountsFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6005Problem with gidNumber in posix group template2022-09-01T09:31:15ZbmortierProblem with gidNumber in posix group template### Description
When you do a posixgroup template, gid number is saved, so when you do a posixgroup gid is the same each time you use this template.
### Distribution Name and Version
Centos 7
### FusionDirectory Version
1.3.0
### ...### Description
When you do a posixgroup template, gid number is saved, so when you do a posixgroup gid is the same each time you use this template.
### Distribution Name and Version
Centos 7
### FusionDirectory Version
1.3.0
### PHP version used
7.1
### Origin of php packages
fusiondirectory
### Steps to Reproduce
<!-- Required -->
1. do a posixgroup template
2. do many posixgroup with this template
3. they all have the same gidNumber
**Expected behavior:**
no gid saved in template
**Actual behavior:**
gid saved in template
**Reproduces how often:**
100%
### Additional InformationFusionDirectory 1.3.1bmortierbmortier