From 7ee453c1c9f53d03c233f6e28b459cc47d82c792 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=B4me=20Chilliet?= <come@opensides.be>
Date: Wed, 18 Apr 2018 09:28:42 +0200
Subject: [PATCH] :ambulance: fix(simpleplugin) Limit Cognitive Complexity
Should fix Sonar warning
issue #5817
---
include/simpleplugin/class_simplePlugin.inc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/simpleplugin/class_simplePlugin.inc b/include/simpleplugin/class_simplePlugin.inc
index 8017282ac..955df166e 100644
--- a/include/simpleplugin/class_simplePlugin.inc
+++ b/include/simpleplugin/class_simplePlugin.inc
@@ -1816,10 +1816,9 @@ class simplePlugin
/* Build DN with multiple attributes */
$usableAttributes = array();
foreach ($this->attributes as $attr) {
- if (($attr == $attribute) || ($this->$attr == '') || is_array($this->$attr)) {
- continue;
+ if (($attr != $attribute) && is_string($this->$attr) && ($this->$attr != '')) {
+ $usableAttributes[] = $attr;
}
- $usableAttributes[] = $attr;
}
for ($i = 2; $i < count($usableAttributes); $i++) {
foreach (new Combinations($usableAttributes, $i) as $attrs) {
--
GitLab