Commit 4f6175ca authored by Côme Chilliet's avatar Côme Chilliet
Browse files

🚑 fix(simpleplugin) Add strict typing to ObjectsAttribute constructor

Helps debugging

issue #5965
parent 55e13734
......@@ -495,7 +495,7 @@ class ObjectsAttribute extends GenericDialogAttribute
public $selectManagementParameters;
function __construct ($label, $description, $ldapName, $required, array $objectTypes, $defaultValue = [], $store_attr = 'dn', $display_attr = 'cn', $acl = '')
function __construct (string $label, string $description, string $ldapName, bool $required, array $objectTypes, array $defaultValue = [], string $store_attr = 'dn', string $display_attr = 'cn', string $acl = '')
{
parent::__construct($label, $description, $ldapName, $required, $defaultValue, $store_attr, $display_attr, $acl);
$this->selectManagementParameters = [
......
  • SonarQube analysis reported 3 issues

    • 2 major
    • 🔽 1 minor

    Note: The following issues were found on lines that were not modified in the commit. Because these issues can't be reported as line comments, they are summarized here:

    1. Remove this commented out code. 📘
    2. Update this method so that its implementation is not identical to "getFilterBlackList" on line 161. 📘
    3. 🔽 Remove this method "__construct" to simply inherit it. 📘
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment