From 35f1ee702511d187ccee0609f5d00f0a6a751a35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=B4me=20Chilliet?= <come.chilliet@fusiondirectory.org>
Date: Mon, 21 Sep 2020 16:26:46 +0200
Subject: [PATCH] :ambulance: fix(setup) Remove check for removed ini
 directives

register_globals was removed in PHP 5.4, and zend.ze1_compatibility_mode
 was removed in PHP 5.3, so it makes no sense checking for their value in
 the setup.
---
 setup/class_setupStepChecks.inc | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/setup/class_setupStepChecks.inc b/setup/class_setupStepChecks.inc
index 92cbcfc44..14a7f534b 100644
--- a/setup/class_setupStepChecks.inc
+++ b/setup/class_setupStepChecks.inc
@@ -152,14 +152,6 @@ class setupStepChecks extends setupStep
 
     /* PHP Configuration checks */
 
-    /* Register_globals off */
-    $N = "register_globals = <b>off</b>";
-    $D = _("register_globals is a PHP mechanism to register all global variables to be accessible from scripts without changing the scope. This may be a security risk.");
-    $S = _("Search for 'register_globals' in your php.ini and switch it to 'Off'.");
-    $R = ini_get("register_globals") == 0;
-    $M = FALSE;
-    $config_checks[] = ["NAME" => $N , "DESC" => $D , "RESULT" => $R , "SOLUTION" => $S , "MUST" => $M ];
-
     /* session lifetime set to >=86400 seconds ? */
     $N = "session.gc_maxlifetime &gt;= <b>86400</b>";
     $D = _("PHP uses this value for the garbage collector to delete old sessions.")." ".
@@ -210,14 +202,6 @@ class setupStepChecks extends setupStep
     $M = FALSE;
     $config_checks[] = ["NAME" => $N , "DESC" => $D , "RESULT" => $R , "SOLUTION" => $S , "MUST" => $M ];
 
-    /* Emulating old stuff? */
-    $N = "zend.ze1_compatibility_mode = <b>"._("Off")."</b>";
-    $D = _("Increase your server performance by setting magic_quotes_gpc to 'off'.");
-    $S = _("Search for 'zend.ze1_compatibility_mode' in your php.ini and set it to 'Off'.");
-    $R = !ini_get('zend.ze1_compatibility_mode');
-    $M = FALSE;
-    $config_checks[] = ["NAME" => $N , "DESC" => $D , "RESULT" => $R , "SOLUTION" => $S , "MUST" => $M ];
-
     $this->basic_checks   = $basic_checks;
     $this->config_checks  = $config_checks;
   }
-- 
GitLab