From 0a61ee896c6e71931db6990b3b4d9a50df525fa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=B4me=20Chilliet?= <come.chilliet@fusiondirectory.org> Date: Thu, 29 Jul 2021 10:16:49 +0200 Subject: [PATCH] :ambulance: fix(ci) Remove non-blocking phpstan step phpstan blocking step is now passing as it should. issue #6134 --- .gitlab-ci.yml | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index df5d5c6a2..12f9db576 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -66,7 +66,7 @@ create_php_code_sniffer_rapport: - PHP_MIN_VERSION=$(grep PHP_MIN_VERSION include/variables_common.inc| cut -d\' -f4| cut -d"." -f 1-2) - phpcs --standard=PHPCompatibility --runtime-set testVersion $PHP_MIN_VERSION- --file-list=./filelist -# phpstan (blocking) +# phpstan create_phpstan_rapport: image: registry.fusiondirectory.org/fusiondirectory/fd/phpstan:buster stage: codestyle @@ -78,23 +78,6 @@ create_phpstan_rapport: - cp ../dev-tools/phpstan/fusiondirectory/1.4-dev/*.neon . - /root/.composer/vendor/bin/phpstan analyse -c phpstan.neon -# phpstan (codequality non blocking showing info in MR) -codequality: - allow_failure: true - image: registry.fusiondirectory.org/fusiondirectory/fd/phpstan:buster - stage: codestyle - only: - - branches - script: - - test -d ../dev-tools/ && rm -Rf ../dev-tools/ - - git clone --depth 1 https://gitlab.fusiondirectory.org/fusiondirectory/dev-tools.git ../dev-tools - - cp ../dev-tools/phpstan/fusiondirectory/1.4-dev/*.neon . - - /root/.composer/vendor/bin/phpstan analyse -c phpstan.neon --error-format gitlab > phpstan.json - artifacts: - when: always - reports: - codequality: phpstan.json - # fusiondirectory-update-locale fusiondirectory-update-locale: image: registry.fusiondirectory.org/fusiondirectory/fd/transifex-cli:stretch -- GitLab