Skip to content
GitLab
    • Explore Projects Groups Topics Snippets
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • fusiondirectory-plugins fusiondirectory-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • fusiondirectoryfusiondirectory
  • fusiondirectory-pluginsfusiondirectory-plugins
  • Issues
  • #5705
Something went wrong while setting issue due date.
Closed
Open
Issue created 7 years ago by bmortier@bmortierMaintainer
  • New related issue

  • New related issue

Make mandatory IPs a configuration option in the systems plugins

Closed

Make mandatory IPs a configuration option in the systems plugins

Description

It bugs me is having the IP field mandatory only in some cases, we should put it either mandatory for all systems or none, or have an option in the configuration back-end.

If it’s non-mandatory by default we can make it mandatory when some tabs are activated (argonautClient for instance needs it).

FusionDirectory Version

1.3-dev

Plugin with the defect

plugin-systems

PHP version used

5.6

Origin of php packages

debian

Steps to Reproduce

  1. Create a system
  2. try to save without an ip
  3. doesnt work

Expected behavior:

  • Make it non mandatory by default, code wise.

  • Have an option in configuration back-end for each of the plugin thats need ip address.

  • Active the option by default, to not change the fonctional usage of people already using it but allowing people to change it if needed.

Actual behavior:

ip is mandatory on all systems and we cannot change that

Reproduces how often:

100%

Additional Information

Make it a configuration option since we changed this too many times already.

Multi-valuated configuration field listing the types for which IP is mandatory.

Note that ipHost have the field ipHostNumber as mandatory so we’ll need to add code to remove this objectClass when the field is empty. This is already what we are doing for phones.

Edited 6 years ago

    Tasks

    0

    No tasks are currently assigned. Use tasks to break down this issue into smaller parts.

    Linked items
    0

    Link issues together to show that they're related. Learn more.

    Activity


    • bmortier mentioned in issue #5702 (moved) 7 years ago

      mentioned in issue #5702 (moved)

    • bmortier changed the description 7 years ago

      changed the description

    • Côme Chilliet created branch 5705-add-ip-non-mandatory-in-the-systems-plugins 7 years ago

      created branch 5705-add-ip-non-mandatory-in-the-systems-plugins

    • Côme Chilliet mentioned in commit 43fbc8a2 7 years ago

      mentioned in commit 43fbc8a2

    • Côme Chilliet added 2h of time spent 7 years ago

      added 2h of time spent

    • Côme Chilliet added To Be Tested label 7 years ago

      added To Be Tested label

    • Côme Chilliet mentioned in issue #5707 (closed) 7 years ago

      mentioned in issue #5707 (closed)

    • bmortier
      bmortier @bmortier · 7 years ago
      Author Maintainer

      Hello,

      tested on workstation and server, works correctly

      Cheers

    • bmortier closed 7 years ago

      closed

    • bmortier added Changed and removed technical discussion labels 7 years ago

      added Changed and removed technical discussion labels

    • bmortier removed To Be Tested label 7 years ago

      removed To Be Tested label

    • bmortier changed title from add ip non mandatory in the systems plugins to Add ip non mandatory in the systems plugins 7 years ago

      changed title from add ip non mandatory in the systems plugins to Add ip non mandatory in the systems plugins

    • Jonathan Swaelens mentioned in issue #5767 (closed) 7 years ago

      mentioned in issue #5767 (closed)

    • Côme Chilliet changed title from Add ip non mandatory in the systems plugins to Make mandatory IPs a configuration option in the systems plugins 6 years ago

      changed title from Add ip non mandatory in the systems plugins to Make mandatory IPs a configuration option in the systems plugins

    Please register or sign in to reply
    Assignee
    Côme Chilliet's avatar
    Côme Chilliet
    Assign to
    Labels
    0
    None
    0
    None
      Assign labels
    • Manage project labels

    Milestone
    No milestone
    None
    Due date
    None
    None
    None
    Time tracking
    No estimate or time spent
    Confidentiality
    Not confidential
    Not confidential

    You are going to turn on confidentiality. Only project members with at least the Reporter role, the author, and assignees can view or be notified about this issue.

    Lock issue
    Unlocked
    0
    0 Participants
    Reference:

    Menu

    Explore Projects Groups Topics Snippets