fusiondirectory-plugins issueshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues2019-08-29T14:08:38Zhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5991ORCID last character may be 'X' and not a number2019-08-29T14:08:38ZCôme ChillietORCID last character may be 'X' and not a numberValid ORCID values are refused by the personal plugin.
Related documentation: https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-IdentifierValid ORCID values are refused by the personal plugin.
Related documentation: https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-IdentifierFusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5963error in SINAPS workflow2022-09-01T10:57:18Zagallavardinerror in SINAPS workflow### Description
It seems that Passport send acquisition ( like role deletion) before sending acknowledgment of diffusion
### Distribution Name and Version
Debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
SINAP
##...### Description
It seems that Passport send acquisition ( like role deletion) before sending acknowledgment of diffusion
### Distribution Name and Version
Debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
SINAP
### PHP version used
7
### Origin of php packages
from debian
### Steps to Reproduce
1. a user is expired on sinaps
2. sinaps send a diffusion
3. FD send acquisition
4. FD send acknoledgement of diffusion
**Expected behavior:**
we must have following order
1. sinaps send diffusion
2. FD acknowledge diffusion
3. FD send acquisition
**Reproduces how often:**
no information
### Additional Information
Message of SINAPS support
> De plus, nous constatons au travers des logs que FUSIONDIRECTORY envoie la suppression du rôle EXT de type "AN" avant d'avoir retourné la réponse d'acquittement (synchrone) de la diffusion.
> De fait, la référence croisée FUSIONDIRECTORY est supprimée dans Sinaps et lorsque l'acquittement arrive, il recherche cette référence croisée qui n'existe plus.
> Cela a pour impact de re-créer une ligne dans la table des références croisées pour laquelle la valeur de la colonne "clé primaire de l'objet métier cible" est vide.
> Il est indispensable que les actions soient traitées dans le bon ordre à savoir :
> - d'abord le retour d'acquittement Synchrone de FUSIONDIRECTORY
> - et ensuite seulement l'envoi par FUSIONDIRECTORY à SINAPS de la suppression
> Cela doit être vu côté FUSIONDIRECTORY.FusionDirectory 1.3.1agallavardinagallavardinhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5901Remove Google+ from personal social accounts tab2019-06-28T20:53:42ZbmortierRemove Google+ from personal social accounts tab## Descriptive title for this enhancement
Add google and remove google+ in "Compte réseau social"
### Actual behavior
actually we store google+ but not google account in the personal plugins
### Expected behavior
* Remove the google...## Descriptive title for this enhancement
Add google and remove google+ in "Compte réseau social"
### Actual behavior
actually we store google+ but not google account in the personal plugins
### Expected behavior
* Remove the google+ from the personal plugin as the network is closed
* Add a possibility to store google account
### Step by step description of new behaviour
<!-- Required -->
1. [First Step]
2. [Second Step]
3. [and so on...]
### Benefits
* Removing no longer supported network
* Add google account
### Possible Drawbacks
none
###
original ticket is in https://gitlab.opensides.be/huma-num-git/support_fusiondirectory/issues/1
CheersFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6100Adding partition for NVME disk in FAI not work correctly2022-09-13T14:42:44ZJonathan SwaelensAdding partition for NVME disk in FAI not work correctly## Descriptive title for this enhancement
Hello, right now FAI add the number of the partition after the disk (hda + 1, sdb + 1 ...).
But for NVME hard drive we have something like "identifier" + p + "partition number".
[create-hdd-fd....## Descriptive title for this enhancement
Hello, right now FAI add the number of the partition after the disk (hda + 1, sdb + 1 ...).
But for NVME hard drive we have something like "identifier" + p + "partition number".
[create-hdd-fd.ldif](/uploads/2e748a809381bbd84f506e47be92d9c1/create-hdd-fd.ldif)
[create-hdd-fd-work-fai.ldif](/uploads/3466a9b24ff9b1dc7d7d8b0714fb3c65/create-hdd-fd-marche-fai.ldif)
### Actual behavior
It only add the partition number
### Expected behavior
We need a proper way to use "p + parition number" for nvme
### Step by step description of new behaviour
1. Go to FAI
2. Create a HDD that use NVME identifier and parition
### Benefits
Proper support of NVME hard drive in FAI
### Possible Drawbacks
NoneFusionDirectory 1.3.1Angaman Ange CedrickAngaman Ange Cedrickhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5957creating icons for the sinaps plugin2019-06-28T20:53:42Zbmortiercreating icons for the sinaps plugin## Descriptive title for this enhancement
creating icons for the sinaps plugin
### Actual behavior
the sinaps plugin is missing an icon in 16px and 48px
### Expected behavior
to be able to show the sinaps icons in the filter list
#...## Descriptive title for this enhancement
creating icons for the sinaps plugin
### Actual behavior
the sinaps plugin is missing an icon in 16px and 48px
### Expected behavior
to be able to show the sinaps icons in the filter list
### Benefits
Be able to select user having sinaps activated in the list or filter
### Possible Drawbacks
noneFusionDirectory 1.3.1animtimanimtimhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5956add mapping sinaps to Fd mapping for diffusion2021-03-24T20:41:08Zagallavardinadd mapping sinaps to Fd mapping for diffusion### Requirements
## Descriptive title for this enhancement
Add mapping sinaps to Fd mapping
### Actual behavior
Actually there is only a mpping FD to SINAPS in case of acquisition.
For diffusion mapping for diffusion is stored in plu...### Requirements
## Descriptive title for this enhancement
Add mapping sinaps to Fd mapping
### Actual behavior
Actually there is only a mpping FD to SINAPS in case of acquisition.
For diffusion mapping for diffusion is stored in plugin core
### Expected behavior
optionnal mapping could be added in order to be more customized depending to sinaps implementation
ex if Contract Date are send from SINAPS a mapping could be done like (example !)
| Xpath | ldap field | transform method |
| ------ | ------ | ------ |
| ElementCarriere/Contrat/dateDebut | fdContractStartDate | convertToFDDate |
| ElementCarriere/Contrat/dateFin | fdContractEndDate | convertToFDDate |
where `convertToFDDate` is a dedicated fonction wich transform `2019-01-15` to `2019011500Z`
### Step by step description of new behaviour
1. Set mapping table inside a dedicated like `FdSinapsDiffusionMap` in sinaps config
2. modify code to use this mapping
### Benefits
More configurable for non mandatory field
### Possible Drawbacks
Complexity, Keep this feature for simple map and transformed attribut : non conditional features
### Applicable IssuesFusionDirectory 1.3.1agallavardinagallavardinhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5940We don't have LDAP tab on FusionDirectory configuration2019-06-28T20:53:42ZJonathan SwaelensWe don't have LDAP tab on FusionDirectory configuration## Descriptive title for this enhancement
We don't have LDAP tab on FusionDirectory configuration
### Actual behavior
After installing ldapdump we don't have LDAP tab on FusionDirectory configuration
### Expected behavior
That we ha...## Descriptive title for this enhancement
We don't have LDAP tab on FusionDirectory configuration
### Actual behavior
After installing ldapdump we don't have LDAP tab on FusionDirectory configuration
### Expected behavior
That we have a LDAP tab to read the configuration
### Step by step description of new behaviour
1. Install ldapdump
2. Go to FD configuration
3. You not see an LDAP tab
### Benefits
Reading the configuration without manual ldapsearchFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5939create icons for ipmi and weblink2019-06-28T20:53:42Zbmortiercreate icons for ipmi and weblink## Descriptive title for this enhancement
<!-- required -->
create an icon for supann status in the user list
### Actual behavior
<!-- What actually happens -->
For now in the systems list of FusionDirectory 1.4 we miss icons for im...## Descriptive title for this enhancement
<!-- required -->
create an icon for supann status in the user list
### Actual behavior
<!-- What actually happens -->
For now in the systems list of FusionDirectory 1.4 we miss icons for impi et weblink
### Expected behavior
<!-- What you expect to happen-->
Have icons in 16px/48px and svg for impi et weblink
### Benefits
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
have icons to show in the filter list
### Possible Drawbacks
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->
noneFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5938Make %passwordClear% available to sambaAccount hooks2019-07-04T13:33:10ZCôme ChillietMake %passwordClear% available to sambaAccount hooksWaiting for something cleaner like fd#5977 , add `%passwordClear%` in the `sambaAccount` tab so that in can be used in hooks for AD sync.Waiting for something cleaner like fd#5977 , add `%passwordClear%` in the `sambaAccount` tab so that in can be used in hooks for AD sync.FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5911supannRefId field is missing for "etablissement"2021-01-28T21:29:10ZagallavardinsupannRefId field is missing for "etablissement"### Requirements
Add the supannRefId field in FD when adding or modifying an "etablissement"
It is allowed by LDAP schema (field member of supannEntite)
### Actual behavior
![image](/uploads/31d07e7fb6b418351d5cfe2f253b0ea1/image.png)...### Requirements
Add the supannRefId field in FD when adding or modifying an "etablissement"
It is allowed by LDAP schema (field member of supannEntite)
### Actual behavior
![image](/uploads/31d07e7fb6b418351d5cfe2f253b0ea1/image.png)
No supannRefId is shown
### Expected behavior
Supann RefId should be available in this interface
dirty fix :
```
root@mc-pas-test:/usr/share/fusiondirectory/plugins/admin/supannStructures# diff class_etablissement.inc class_etablissement.inc.init
117,125d116
< new SetAttribute(
< new StringAttribute(
< _('Reference IDs'), _('supannRefId - IDs/links for this entity on other systems'),
< 'supannRefId', FALSE,
< '', '',
< // Validation regexp: it must have a prefix
< '/^{[^}]+}.+$/'
< )
< ),
```FusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6180[CodeStyle] 1.3.1 Plugin - Requires adaptation to align code style with 1.42022-09-12T13:30:49Zdockx thibault[CodeStyle] 1.3.1 Plugin - Requires adaptation to align code style with 1.4### Requirements
## Descriptive title for this enhancement
Current customer release 1.3.1 (1.3-fixes) uses old PHP code style, which requires updates to have equivalence with release 1.4-dev.
This will allow uniformization between th...### Requirements
## Descriptive title for this enhancement
Current customer release 1.3.1 (1.3-fixes) uses old PHP code style, which requires updates to have equivalence with release 1.4-dev.
This will allow uniformization between the two releases.
### Actual behavior
Old code style
### Expected behavior
Usage of the new code style
### Step by step description of new behaviour
Apply new codestyle from latest branch update
### Benefits
Uniformization of code.
### Possible Drawbacks
Possible tests failing due to mistake introduce during code modification.
### Applicable Issues
NoneFusionDirectory 1.3.1dockx thibaultdockx thibaulthttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6103Adapt 1.3-fixes code to subscription core merge2022-09-09T08:27:52ZCôme ChillietAdapt 1.3-fixes code to subscription core mergeFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5993_getTabFooter has been renamed getTabFooter2021-01-28T21:04:26ZCôme Chilliet_getTabFooter has been renamed getTabFooterBecause of fd#5974 changes, we need to adapt code in argonaut pluginBecause of fd#5974 changes, we need to adapt code in argonaut pluginFusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5948description of a user should'nt be updated from SINAPS2019-06-28T20:53:42Zagallavardindescription of a user should'nt be updated from SINAPS### Description
Description is updated from sinaps, Finally it isn't a good idea
### Distribution Name and Version
debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
sinaps
### PHP version used
7
### Origin of php pa...### Description
Description is updated from sinaps, Finally it isn't a good idea
### Distribution Name and Version
debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
sinaps
### PHP version used
7
### Origin of php packages
debian
### Steps to Reproduce
1. set a accoutn on Fd with a description
2. Sync the Id( with a blank description from sinaps to FD
**Expected behavior:**
description shouldn't be synced
**Actual behavior:**
description is synced
**Reproduces how often:**
100 %
### Additional Information
remove line 213 inside include/class_sinapsRequest.inc should do the trickFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5913Avoid mass acquistion when editing group gidNumber2019-06-28T20:53:42ZagallavardinAvoid mass acquistion when editing group gidNumber### Requirements
## Descriptive title for this enhancement
### Actual behavior
When a posix group is deleted or modified ( like modified the gidNumber or name ), Fd check consistency on all people which user the posixAccount feature.
...### Requirements
## Descriptive title for this enhancement
### Actual behavior
When a posix group is deleted or modified ( like modified the gidNumber or name ), Fd check consistency on all people which user the posixAccount feature.
By checking consistency of all account and if SINAPS is enabled all account is scanned and corresponding acquisition is sent
I see in log ldap request to get all attribute sent to sinaps
```
Jan 25 10:15:28 mc-pas-test slapd[698]: conn=17763 op=21987 SRCH attr=supannRefId supannEntiteAffectationPrincipale telephoneNumber facsimileTelephoneNumber mail mobi
le dn
```
for one modification I see 382 request
```
root@mc-pas-test:/var/cache/fusiondirectory/tmp# grep " SRCH attr=supannRefId supannEntiteAffectationPrincipale" /var/log/syslog |grep 17763 |wc -l
382
```
which is corresponding to posixuser concerned by the modified group
### Expected behavior
Acquisition is sent only when field specified in fdSinapsAcquisitionContactMethodMap are modified
### Step by step description of new behaviour
1. modify/delete a group
2. as this change didn't concern to sinaps information no acquisition should be launched
### Benefits
group modification more quick
### Possible Drawbacks
code complexity
### additional information
It seems that modification launch other actions like mailbox check ( partage for example)FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5897When a user is removed from Sinaps, we need to send back a deletion acquisition2019-08-29T13:22:20ZCôme ChillietWhen a user is removed from Sinaps, we need to send back a deletion acquisitionhttps://gitlab.opensides.be/irstea-git/sinaps/issues/13https://gitlab.opensides.be/irstea-git/sinaps/issues/13FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6125PHP error: Array to string conversion in class_fiInventory.inc:1992022-09-01T09:36:55ZCôme ChillietPHP error: Array to string conversion in class_fiInventory.inc:199Only in 1.3 branch:
```
=== Error ===
PHP error: Array to string conversion
(/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc,
line 199)
=== /Error ===
=== Trace ===
Trace[1]:function implode
Fil...Only in 1.3 branch:
```
=== Error ===
PHP error: Array to string conversion
(/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc,
line 199)
=== /Error ===
=== Trace ===
Trace[1]:function implode
File :
/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc
Line : 199
Type : -
")(macAddress=",array(array("96:00:00:14:4b:82"))
```FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6079reload dns map from dns interface didn't work , but from server it works2021-08-25T18:45:50Zagallavardinreload dns map from dns interface didn't work , but from server it works### Description
Try to reload map from DNS main interface : it didn't work :
![image](/uploads/3815761c91542eced7436083e7648667/image.png)
I add a data::dumper trace on Argonaut client :
```
Nov 11 16:22:39 [NOTICE] ldap2zone called zo...### Description
Try to reload map from DNS main interface : it didn't work :
![image](/uploads/3815761c91542eced7436083e7648667/image.png)
I add a data::dumper trace on Argonaut client :
```
Nov 11 16:22:39 [NOTICE] ldap2zone called zone: $VAR1 = [
'demo.fusion.'
];
```
Try to reload from serveur view : it's work
![image](/uploads/18dd67beb8123ede21958d8c002a11ea/image.png)
Trace from argonaut client :
`Nov 11 16:31:16 [NOTICE] ldap2zone called zone: $VAR1 = 'demo.fusion.';`
see the difference : from DNS main interface, an array is sent, from server interface it's a string
### Distribution Name and Version
Debian Stretch
### FusionDirectory Version
from git
```
root@fd-14-dev:/usr/local/src/fd-plugins# git show
commit 573c517c78477d75d3a32d3961a3a8c6156fa938 (HEAD -> 1.4-dev, origin/HEAD, origin/1.4-dev)
```
### Plugin with the defect
dns
### PHP version used
`ii php7.3 7.3.19-1~deb10u1 `
### Steps to Reproduce
1. create a single dns zone
2. reload it from DNS main interface : FAIL
3. reload it from DNS tab in Server main interface : WORKS
**Reproduces how often:**
100%FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6063Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type a...2020-10-19T13:39:05ZCôme ChillietArgument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string givenFrom https://github.com/fusiondirectory/fusiondirectory-plugins/issues/24
```
PHP Fatal error:
Uncaught TypeError: Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string given, called in
/usr/share/fu...From https://github.com/fusiondirectory/fusiondirectory-plugins/issues/24
```
PHP Fatal error:
Uncaught TypeError: Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string given, called in
/usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc on line 405 and defined in /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc:159
Stack trace:
#0 /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc(405): DhcpHostsAttribute->postLdapSave(Object(ldapMultiplexer), false, false, '10.168.1.20', '10.168.1.20', false, '00:02:d1:08:05:...', '00:02:d1:08:05:...')
#1 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1226): dhcpSystem->ldap_save()
#2 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(430): simplePlugin->save()
#3 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(828): simpleTabs->save()
#4 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(945): simpleManagement->applyChanges('apply', Array, Array)
#5 /usr/share/fusiondirectory/includ in /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc on line 159, referer: http://10.0.173.187/main.php?plug=81
```FusionDirectory 1.3.1https://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6000correct the get help section in the readme.md2021-03-15T16:55:16Zbmortiercorrect the get help section in the readme.mdcorrect the get help section in the readme.md
hello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirec...correct the get help section in the readme.md
hello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirectory-plugins/issues/22
cheersFusionDirectory 1.3.1bmortierbmortier