fusiondirectory-plugins issueshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues2022-09-08T14:17:17Zhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6183remove all reference to stretch registry images2022-09-08T14:17:17Zbmortierremove all reference to stretch registry imagesHello,
we need to remove all reference to stretch images in the registry
CheersHello,
we need to remove all reference to stretch images in the registry
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6182make all docker images come from the /fd registry2022-07-28T18:29:38Zbmortiermake all docker images come from the /fd registry## Descriptive title for this enhancement
make all docker images come from the /fd registry
<!-- required -->
### Actual behavior
some images come from the fd-plugins registry, it make no sense to have twice the same images
<!-- Wha...## Descriptive title for this enhancement
make all docker images come from the /fd registry
<!-- required -->
### Actual behavior
some images come from the fd-plugins registry, it make no sense to have twice the same images
<!-- What actually happens -->
### Expected behavior
ci is using images from /fd
<!-- What you expect to happen-->
### Benefits
all images come from the same registry
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
### Possible Drawbacks
none
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6181[CodeStyle] - CI Update - Usage of the latest code style rules.2022-09-12T13:56:34Zdockx thibault[CodeStyle] - CI Update - Usage of the latest code style rules.### Requirements
* Filling out the template is required. Any Enhancement request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
* All new code requires tests to e...### Requirements
* Filling out the template is required. Any Enhancement request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
* All new code requires tests to ensure against regressions
## Descriptive title for this enhancement
1.3.1 uses an old codestyle and it has been agreed to change it to correspond to 1.4 (actual version to date).
### Actual behavior
Old codestyle is being used
### Expected behavior
New codestyle is being used
### Step by step description of new behaviour
```yaml
# PHP codesniffer
create_php_code_sniffer_rapport:
image: registry.fusiondirectory.org/fusiondirectory/fd/phpcodesniffer-cli:stretch
stage: codestyle
only:
- branches
script:
- test -d ../dev-tools/ && rm -Rf ../dev-tools/
- git clone --depth 1 https://gitlab.fusiondirectory.org/fusiondirectory/dev-tools.git -b 1.3 ../dev-tools
- find . -type f -name '*.php' -o -name '*.inc' > ./filelist
- phpcs --standard=../dev-tools/php-codesniffer-rules/FDStandard/ruleset.xml --file-list=./filelist
```
change the git clone with proper updated branch reflecting latest up to date branch.
### Benefits
Code style will be aligned everywhere.
### Possible Drawbacks
Possible risk of automated-testing reporting issues for mistakes introduced during code style changes.
No php lint errors must be reported prior of changing the CI.
### Applicable Issues
NoneFusionDirectory 1.3.1dockx thibaultdockx thibaulthttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6180[CodeStyle] 1.3.1 Plugin - Requires adaptation to align code style with 1.42022-09-12T13:30:49Zdockx thibault[CodeStyle] 1.3.1 Plugin - Requires adaptation to align code style with 1.4### Requirements
## Descriptive title for this enhancement
Current customer release 1.3.1 (1.3-fixes) uses old PHP code style, which requires updates to have equivalence with release 1.4-dev.
This will allow uniformization between th...### Requirements
## Descriptive title for this enhancement
Current customer release 1.3.1 (1.3-fixes) uses old PHP code style, which requires updates to have equivalence with release 1.4-dev.
This will allow uniformization between the two releases.
### Actual behavior
Old code style
### Expected behavior
Usage of the new code style
### Step by step description of new behaviour
Apply new codestyle from latest branch update
### Benefits
Uniformization of code.
### Possible Drawbacks
Possible tests failing due to mistake introduce during code modification.
### Applicable Issues
NoneFusionDirectory 1.3.1dockx thibaultdockx thibaulthttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6125PHP error: Array to string conversion in class_fiInventory.inc:1992022-09-01T09:36:55ZCôme ChillietPHP error: Array to string conversion in class_fiInventory.inc:199Only in 1.3 branch:
```
=== Error ===
PHP error: Array to string conversion
(/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc,
line 199)
=== /Error ===
=== Trace ===
Trace[1]:function implode
Fil...Only in 1.3 branch:
```
=== Error ===
PHP error: Array to string conversion
(/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc,
line 199)
=== /Error ===
=== Trace ===
Trace[1]:function implode
File :
/usr/share/fusiondirectory/plugins/admin/systems/fusioninventory/class_fiInventory.inc
Line : 199
Type : -
")(macAddress=",array(array("96:00:00:14:4b:82"))
```FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6103Adapt 1.3-fixes code to subscription core merge2022-09-09T08:27:52ZCôme ChillietAdapt 1.3-fixes code to subscription core mergeFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6101Postfix Service Plugin - 'Domains and routing' fields not saved2022-09-01T10:50:32ZLong BenjaminPostfix Service Plugin - 'Domains and routing' fields not saved### Description
When adding a Postfix service to a server, none of the settings on the right hand side (that is, everything under 'Domains and routing') are ever saved to LDAP.
However, if I edit the LDAP record and add a 'postfixMyDesti...### Description
When adding a Postfix service to a server, none of the settings on the right hand side (that is, everything under 'Domains and routing') are ever saved to LDAP.
However, if I edit the LDAP record and add a 'postfixMyDestinations' attribute to the server record, that will show up under 'Domains to accept mail for' section.
<!-- Required -->
<!-- Description of the issue -->
### Distribution Name and Version
Ubuntu 20.04
<!-- Required -->
<!-- Debian, Centos -->
### FusionDirectory Version
1.3
<!-- Required -->
### Plugin with the defect
fusiondirectory-plugin-postfix
<!-- Required -->
<!-- Name of the plugin -->
### PHP version used
7.4. I also tried it with 7.3 with the same result.
<!-- Required -->
### Origin of php packages
7.4 = Official Ubuntu 20.04 packages.
7.3 = ppa:ondrej/php
<!-- Required -->
<!-- Distribution packages, Out of distribution -->
### Steps to Reproduce
<!-- Required -->
1. In 'Systems' create an entry.
2. In that system, add a new service of type 'Postfix (SMTP)'
3. In that service, add a domain under 'Domains to accept mail for' and save.
4. Check your LDAP record and notice that the domain was not added
5. Go to the home page, then back to the service (so the local cache refreshes).
6. Go back to the service record, and notice that the 'Domains to accept mail for' section is blank.
**Expected behavior:**
When a record is added in Fusiondirectory under the 'Domains and routing' section, the corresponding LDAP attributes should be added to the LDAP record.
<!-- What you expect to happen-->
**Actual behavior:**
None of the records under the 'Domains and routing' section are ever saved to LDAP.
<!-- What actually happens -->
**Reproduces how often:**
<!-- What percentage of the time does it reproduce?-->
100%. Every time.
### Additional Information
<!-- optional -->
<!-- Any additional information, configuration or data that might be necessary to reproduce the issue. -->
I don't think there are any updates to this plugin since 1.3 was first released, at least as far as I can tell via the git repo.FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6100Adding partition for NVME disk in FAI not work correctly2022-09-13T14:42:44ZJonathan SwaelensAdding partition for NVME disk in FAI not work correctly## Descriptive title for this enhancement
Hello, right now FAI add the number of the partition after the disk (hda + 1, sdb + 1 ...).
But for NVME hard drive we have something like "identifier" + p + "partition number".
[create-hdd-fd....## Descriptive title for this enhancement
Hello, right now FAI add the number of the partition after the disk (hda + 1, sdb + 1 ...).
But for NVME hard drive we have something like "identifier" + p + "partition number".
[create-hdd-fd.ldif](/uploads/2e748a809381bbd84f506e47be92d9c1/create-hdd-fd.ldif)
[create-hdd-fd-work-fai.ldif](/uploads/3466a9b24ff9b1dc7d7d8b0714fb3c65/create-hdd-fd-marche-fai.ldif)
### Actual behavior
It only add the partition number
### Expected behavior
We need a proper way to use "p + parition number" for nvme
### Step by step description of new behaviour
1. Go to FAI
2. Create a HDD that use NVME identifier and parition
### Benefits
Proper support of NVME hard drive in FAI
### Possible Drawbacks
NoneFusionDirectory 1.3.1Angaman Ange CedrickAngaman Ange Cedrickhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6087add a security.md for github compliance2021-03-15T16:41:17Zbmortieradd a security.md for github complianceHello,
we need a security.md for github compliance
we can use https://www.fusiondirectory.org/en/security/
CheersHello,
we need a security.md for github compliance
we can use https://www.fusiondirectory.org/en/security/
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6079reload dns map from dns interface didn't work , but from server it works2021-08-25T18:45:50Zagallavardinreload dns map from dns interface didn't work , but from server it works### Description
Try to reload map from DNS main interface : it didn't work :
![image](/uploads/3815761c91542eced7436083e7648667/image.png)
I add a data::dumper trace on Argonaut client :
```
Nov 11 16:22:39 [NOTICE] ldap2zone called zo...### Description
Try to reload map from DNS main interface : it didn't work :
![image](/uploads/3815761c91542eced7436083e7648667/image.png)
I add a data::dumper trace on Argonaut client :
```
Nov 11 16:22:39 [NOTICE] ldap2zone called zone: $VAR1 = [
'demo.fusion.'
];
```
Try to reload from serveur view : it's work
![image](/uploads/18dd67beb8123ede21958d8c002a11ea/image.png)
Trace from argonaut client :
`Nov 11 16:31:16 [NOTICE] ldap2zone called zone: $VAR1 = 'demo.fusion.';`
see the difference : from DNS main interface, an array is sent, from server interface it's a string
### Distribution Name and Version
Debian Stretch
### FusionDirectory Version
from git
```
root@fd-14-dev:/usr/local/src/fd-plugins# git show
commit 573c517c78477d75d3a32d3961a3a8c6156fa938 (HEAD -> 1.4-dev, origin/HEAD, origin/1.4-dev)
```
### Plugin with the defect
dns
### PHP version used
`ii php7.3 7.3.19-1~deb10u1 `
### Steps to Reproduce
1. create a single dns zone
2. reload it from DNS main interface : FAIL
3. reload it from DNS tab in Server main interface : WORKS
**Reproduces how often:**
100%FusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6073Add tar.gz build pour fixes packages2021-03-15T16:47:58ZJonathan SwaelensAdd tar.gz build pour fixes packages## Descriptive title for this enhancement
Add tar.gz build pour fixes packages
### Actual behavior
We only build dev for now
### Expected behavior
Building fixes packages with the CI
### Benefits
The build would be auto after merge## Descriptive title for this enhancement
Add tar.gz build pour fixes packages
### Actual behavior
We only build dev for now
### Expected behavior
Building fixes packages with the CI
### Benefits
The build would be auto after mergeFusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6070change the donate part to add all the crowfunding possibilities2022-09-13T14:35:05Zbmortierchange the donate part to add all the crowfunding possibilitieshello,
we need to replace the donate with all our crowfunding possibilities
Cheershello,
we need to replace the donate with all our crowfunding possibilities
CheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6066add the markdown for the best practice badge https://bestpractices.coreinfras...2022-09-01T11:06:11Zbmortieradd the markdown for the best practice badge https://bestpractices.coreinfrastructure.org/hello,
we need to add the markdown for the best practice badge https://bestpractices.coreinfrastructure.org/en/projects/351
cheershello,
we need to add the markdown for the best practice badge https://bestpractices.coreinfrastructure.org/en/projects/351
cheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6063Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type a...2020-10-19T13:39:05ZCôme ChillietArgument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string givenFrom https://github.com/fusiondirectory/fusiondirectory-plugins/issues/24
```
PHP Fatal error:
Uncaught TypeError: Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string given, called in
/usr/share/fu...From https://github.com/fusiondirectory/fusiondirectory-plugins/issues/24
```
PHP Fatal error:
Uncaught TypeError: Argument 4 passed to DhcpHostsAttribute::postLdapSave() must be of the type array, string given, called in
/usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc on line 405 and defined in /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc:159
Stack trace:
#0 /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc(405): DhcpHostsAttribute->postLdapSave(Object(ldapMultiplexer), false, false, '10.168.1.20', '10.168.1.20', false, '00:02:d1:08:05:...', '00:02:d1:08:05:...')
#1 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1226): dhcpSystem->ldap_save()
#2 /usr/share/fusiondirectory/include/simpleplugin/class_simpleTabs.inc(430): simplePlugin->save()
#3 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(828): simpleTabs->save()
#4 /usr/share/fusiondirectory/include/simpleplugin/class_simpleManagement.inc(945): simpleManagement->applyChanges('apply', Array, Array)
#5 /usr/share/fusiondirectory/includ in /usr/share/fusiondirectory/plugins/admin/systems/class_dhcpSystem.inc on line 159, referer: http://10.0.173.187/main.php?plug=81
```FusionDirectory 1.3.1https://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6056add a .github/FUNDING.yml2021-04-19T15:16:13Zbmortieradd a .github/FUNDING.yml## Descriptive title for this enhancement
<!-- required -->
github now allows to put sponsoring links to the repository for the various monetary contributing platforms
### Actual behavior
<!-- What actually happens -->
no link to ou...## Descriptive title for this enhancement
<!-- required -->
github now allows to put sponsoring links to the repository for the various monetary contributing platforms
### Actual behavior
<!-- What actually happens -->
no link to our donating platforms
### Expected behavior
<!-- What you expect to happen-->
be able to promote crowfunding platform
### Step by step description of new behaviour
we need to add a .github/FUNDING.yml
### Benefits
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
raise awardness of way of micro donating to fusiondirectory
### Possible Drawbacks
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->
none
### Applicable Issues
<!-- optional -->
<!-- Enter any applicable Issues here -->
crowfundingFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6000correct the get help section in the readme.md2021-03-15T16:55:16Zbmortiercorrect the get help section in the readme.mdcorrect the get help section in the readme.md
hello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirec...correct the get help section in the readme.md
hello,
we need to coorect the get help in the readme.md
we have to split community support form commercial support
we got a ticket in github https://github.com/fusiondirectory/fusiondirectory-plugins/issues/22
cheersFusionDirectory 1.3.1bmortierbmortierhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5993_getTabFooter has been renamed getTabFooter2021-01-28T21:04:26ZCôme Chilliet_getTabFooter has been renamed getTabFooterBecause of fd#5974 changes, we need to adapt code in argonaut pluginBecause of fd#5974 changes, we need to adapt code in argonaut pluginFusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5992Email icon should be moved to core2019-08-29T13:23:18ZCôme ChillietEmail icon should be moved to coreSee fd#6023See fd#6023FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5991ORCID last character may be 'X' and not a number2019-08-29T14:08:38ZCôme ChillietORCID last character may be 'X' and not a numberValid ORCID values are refused by the personal plugin.
Related documentation: https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-IdentifierValid ORCID values are refused by the personal plugin.
Related documentation: https://support.orcid.org/hc/en-us/articles/360006897674-Structure-of-the-ORCID-IdentifierFusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelenshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5978GPG key addition crash2021-01-03T13:49:05ZPatzke ThomasGPG key addition crash### Description
Uploading of a PGP Key via the web interface caused an exception.
### Distribution Name and Version
Ubuntu 16.04
### FusionDirectory Version
1.3
### Plugin with the defect
gpg
### PHP version used
7.0.4
### Orig...### Description
Uploading of a PGP Key via the web interface caused an exception.
### Distribution Name and Version
Ubuntu 16.04
### FusionDirectory Version
1.3
### Plugin with the defect
gpg
### PHP version used
7.0.4
### Origin of php packages
Debian Repository *debian-stretch* from repos.fusiondirectory.org
### Steps to Reproduce
1. Login to Fusion Directory
2. Click on GPG
3. Click on Add button
4. Select an entry and add it
**Expected behavior:**
Key is added
**Actual behavior:**
Exception is thrown.
**Reproduces how often:**
100%
### Additional Information
I've provided a fix: https://gitlab.fusiondirectory.org/pthomas/fd-plugins/commit/3618a5a0e9382b46dfb21b8f908f548a87452c5b
Unfortunately I'm not able to make a merge request. The fix is tested in our environment.FusionDirectory 1.3.1Jonathan SwaelensJonathan Swaelens