fusiondirectory-plugins issueshttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues2023-03-13T16:04:22Zhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6071Adapt plugins code to dialog classes refactor2023-03-13T16:04:22ZCôme ChillietAdapt plugins code to dialog classes refactorAdapt all plugins to fd#6072 refactor.
Extra care should be put into webservice plugin to cleanup POST reading and render which should not happen when using FD through webservice.Adapt all plugins to fd#6072 refactor.
Extra care should be put into webservice plugin to cleanup POST reading and render which should not happen when using FD through webservice.FusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5889Add cache for sinaps UUID lookups2023-03-13T15:59:31ZCôme ChillietAdd cache for sinaps UUID lookups`sinapsDiffusionHandlerJob::ldapUuidToCodeEntite` and `sinapsUser::codeEntiteToldapUuidCallback` should both have a cache to reduce LDAP calls.
(from TODO notes in the code)
Related to #5869`sinapsDiffusionHandlerJob::ldapUuidToCodeEntite` and `sinapsUser::codeEntiteToldapUuidCallback` should both have a cache to reduce LDAP calls.
(from TODO notes in the code)
Related to #5869FusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5963error in SINAPS workflow2022-09-01T10:57:18Zagallavardinerror in SINAPS workflow### Description
It seems that Passport send acquisition ( like role deletion) before sending acknowledgment of diffusion
### Distribution Name and Version
Debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
SINAP
##...### Description
It seems that Passport send acquisition ( like role deletion) before sending acknowledgment of diffusion
### Distribution Name and Version
Debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
SINAP
### PHP version used
7
### Origin of php packages
from debian
### Steps to Reproduce
1. a user is expired on sinaps
2. sinaps send a diffusion
3. FD send acquisition
4. FD send acknoledgement of diffusion
**Expected behavior:**
we must have following order
1. sinaps send diffusion
2. FD acknowledge diffusion
3. FD send acquisition
**Reproduces how often:**
no information
### Additional Information
Message of SINAPS support
> De plus, nous constatons au travers des logs que FUSIONDIRECTORY envoie la suppression du rôle EXT de type "AN" avant d'avoir retourné la réponse d'acquittement (synchrone) de la diffusion.
> De fait, la référence croisée FUSIONDIRECTORY est supprimée dans Sinaps et lorsque l'acquittement arrive, il recherche cette référence croisée qui n'existe plus.
> Cela a pour impact de re-créer une ligne dans la table des références croisées pour laquelle la valeur de la colonne "clé primaire de l'objet métier cible" est vide.
> Il est indispensable que les actions soient traitées dans le bon ordre à savoir :
> - d'abord le retour d'acquittement Synchrone de FUSIONDIRECTORY
> - et ensuite seulement l'envoi par FUSIONDIRECTORY à SINAPS de la suppression
> Cela doit être vu côté FUSIONDIRECTORY.FusionDirectory 1.3.1agallavardinagallavardinhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6061Adapt plugins code to changes on error system2021-07-29T19:49:51ZCôme ChillietAdapt plugins code to changes on error systemRelated to fd#6071Related to fd#6071FusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5956add mapping sinaps to Fd mapping for diffusion2021-03-24T20:41:08Zagallavardinadd mapping sinaps to Fd mapping for diffusion### Requirements
## Descriptive title for this enhancement
Add mapping sinaps to Fd mapping
### Actual behavior
Actually there is only a mpping FD to SINAPS in case of acquisition.
For diffusion mapping for diffusion is stored in plu...### Requirements
## Descriptive title for this enhancement
Add mapping sinaps to Fd mapping
### Actual behavior
Actually there is only a mpping FD to SINAPS in case of acquisition.
For diffusion mapping for diffusion is stored in plugin core
### Expected behavior
optionnal mapping could be added in order to be more customized depending to sinaps implementation
ex if Contract Date are send from SINAPS a mapping could be done like (example !)
| Xpath | ldap field | transform method |
| ------ | ------ | ------ |
| ElementCarriere/Contrat/dateDebut | fdContractStartDate | convertToFDDate |
| ElementCarriere/Contrat/dateFin | fdContractEndDate | convertToFDDate |
where `convertToFDDate` is a dedicated fonction wich transform `2019-01-15` to `2019011500Z`
### Step by step description of new behaviour
1. Set mapping table inside a dedicated like `FdSinapsDiffusionMap` in sinaps config
2. modify code to use this mapping
### Benefits
More configurable for non mandatory field
### Possible Drawbacks
Complexity, Keep this feature for simple map and transformed attribut : non conditional features
### Applicable IssuesFusionDirectory 1.3.1agallavardinagallavardinhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5869Merge the sinaps plugin into 1.3-dev when completed2021-01-29T20:47:49ZbmortierMerge the sinaps plugin into 1.3-dev when completedHello,
we got the ok from amue to merge the sinaps plusing into 1.3-dev, so the plugin must be merged as soon as the latest detail are cleaned.
1.3 will be releases with the sinaps plugin
CheersHello,
we got the ok from amue to merge the sinaps plusing into 1.3-dev, so the plugin must be merged as soon as the latest detail are cleaned.
1.3 will be releases with the sinaps plugin
CheersCôme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5930Move complex plugins configurations to their own tab2021-01-29T14:46:36ZbmortierMove complex plugins configurations to their own tab### Actual behavior
<!-- What actually happens -->
Actually some plugins that need to have something configured is in the plugins tab, even complex one. This became too crowded and not visually nice nor usefull. Complex configuration s...### Actual behavior
<!-- What actually happens -->
Actually some plugins that need to have something configured is in the plugins tab, even complex one. This became too crowded and not visually nice nor usefull. Complex configuration should be moved to their own tab in the configuration screen.
### Expected behavior
<!-- What you expect to happen-->
Move the complex configuration to their own plugin tab in the configuration backend :
* SupAnn
* Invitation
* Sinaps
* Dashboard
### Benefits
<!-- optional -->
<!-- What benefits will be realized by the code change? -->
* More clean plugins tab
* More user friendly specialized tabs
### Possible Drawbacks
<!-- optional -->
<!-- What are the possible side-effects or negative impacts of the code change? -->
noneFusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5933Reorder configuration tabs2021-01-29T14:44:43ZCôme ChillietReorder configuration tabsSee fd#5971See fd#5971FusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/6016Sinaps have continue calls targetting switches2021-01-28T20:42:42ZCôme ChillietSinaps have continue calls targetting switchesThis triggers warning in PHP 7.3, and does not make sense.
https://www.php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switchThis triggers warning in PHP 7.3, and does not make sense.
https://www.php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switchFusionDirectory 1.4Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5909plugin sinaps : check if there is only one SINAPS UUID in ldap leaf of a user2020-10-19T14:01:05Zagallavardinplugin sinaps : check if there is only one SINAPS UUID in ldap leaf of a user### Requirements
## Descriptive title for this enhancement
there is only one or none SINAPS ID in supannRefId
### Actual behavior
du to some replication task or bad manipulation, we ( in our system) have got 2 sinaps Id for one user
...### Requirements
## Descriptive title for this enhancement
there is only one or none SINAPS ID in supannRefId
### Actual behavior
du to some replication task or bad manipulation, we ( in our system) have got 2 sinaps Id for one user
### Expected behavior
A check should be done . If more than one sinaps id is detected an error should occurs ( otherwise SINAPS didn't syunc anything)
### Benefits
more coherenceCôme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5912Unable to spread a user to FD from sinaps if the user is affected to an etabl...2020-02-05T09:44:35ZagallavardinUnable to spread a user to FD from sinaps if the user is affected to an etablissement### Description
Unable to spread a user to FD from sinaps if the user belong to the main structure ( etablissement)
### Distribution Name and Version
debian stretch
### FusionDirectory Version
1.3 dev
### Plugin with the defect
si...### Description
Unable to spread a user to FD from sinaps if the user belong to the main structure ( etablissement)
### Distribution Name and Version
debian stretch
### FusionDirectory Version
1.3 dev
### Plugin with the defect
sinaps ou supann ( maybe related to #5911 )
### PHP version used
php7
### Origin of php packages
from debian official repository
### Steps to Reproduce
1. all structure ares synced between SINAPS and FD
2. on sinaps, the user belong to the main structure : the establishment
3. when user is spread to FD, the main structure isn't found
**Expected behavior:**
user should be spread successfully
**Actual behavior:**
error occurs : `<messageAcquittement>Could not find entite {LDAPUUID}3ba4a924-9bb8-5745-b9f1-fc7347bff2b5</messageAcquittement><codeAcquittement>`
**Reproduces how often:**
100%
### Additional Information
by there is a link with #5911FusionDirectory 1.3.1agallavardinagallavardinhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5943SINAPS : if contact method are not the same or missing in sinaps , acquisitio...2019-09-24T10:32:38ZagallavardinSINAPS : if contact method are not the same or missing in sinaps , acquisition must be sent### Requirements
## Descriptive title for this enhancement
when diffusion is done, contact method must be compared, if there are different or not exist on SINAPS, acquisition must be done
### Actual behavior
no acquisition is done af...### Requirements
## Descriptive title for this enhancement
when diffusion is done, contact method must be compared, if there are different or not exist on SINAPS, acquisition must be done
### Actual behavior
no acquisition is done after diffusion
### Expected behavior
when diffusion is done, contact method must be compared, if there are different or not exist on SINAPS, acquisition must be done
### Step by step description of new behaviour
1. diffusion is done to Fusion
2. compare contact method from sinaps and Fusion , if different ( incorrect or missing on sinaps side) an acquisition is mandatory
3. lanch acquisition if necesary
### Benefits
coherence between SINAPS an FDCôme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5897When a user is removed from Sinaps, we need to send back a deletion acquisition2019-08-29T13:22:20ZCôme ChillietWhen a user is removed from Sinaps, we need to send back a deletion acquisitionhttps://gitlab.opensides.be/irstea-git/sinaps/issues/13https://gitlab.opensides.be/irstea-git/sinaps/issues/13FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5945unable to add SINAPS Structure2019-06-28T20:53:44Zagallavardinunable to add SINAPS Structure### Description
unabel to add structure, PHP error occurs
### Distribution Name and Version
Debian 9
### FusionDirectory Version
1.3-2~jenkinsbuild113
### Plugin with the defect
fusiondirectory-plugin-sinaps 1.3-2~jenkinsbuild...### Description
unabel to add structure, PHP error occurs
### Distribution Name and Version
Debian 9
### FusionDirectory Version
1.3-2~jenkinsbuild113
### Plugin with the defect
fusiondirectory-plugin-sinaps 1.3-2~jenkinsbuild113
### PHP version used
7
### Origin of php packages
from debian reository
### Steps to Reproduce
1. create structure on sinaps
2. push it on FusionDirectory
**Expected behavior:**
A new structure is create and Id sent to sinaps
**Actual behavior:**
php Error
```
php /usr/share/doc/fusiondirectory-plugin-sinaps/test/testEndPoint.php http://fd-server/sinaps.php?token=991997f4-a48f-4e8d-87e5-78432fbe80ed ./ee67e316-6e9b-4d0a-9935-b8c523ef1db0.xml
***** Server response *****
<br />
<b>Fatal error</b>: Uncaught InvalidValueException: SetAttribute "Parent entities" was set to a non-compatible value in /usr/share/fusiondirectory/include/simpleplugin/attributes/class_SetAttribute.inc:352
Stack trace:
#0 /usr/share/fusiondirectory/include/simpleplugin/class_Attribute.inc(164): SetAttribute->checkValue('DAFA')
#1 /usr/share/fusiondirectory/include/simpleplugin/class_Attribute.inc(643): Attribute->setValue('DAFA')
#2 /usr/share/fusiondirectory/include/simpleplugin/class_simplePlugin.inc(1938): Attribute->deserializeValue('DAFA')
#3 /usr/share/fusiondirectory/include/class_sinapsDiffusionHandlerJob.inc(255): simplePlugin->deserializeValues(Array)
#4 /usr/share/fusiondirectory/include/class_sinapsDiffusionHandlerJob.inc(136): sinapsDiffusionHandlerJob->fillObject('entite', Array, 'supannCodeEntit...')
#5 /usr/share/fusiondirectory/include/class_sinapsDiffusionHandlerJob.inc(59): sinapsDiffusionHandlerJob->handleStructureDiffusion(Array)
#6 /usr/share/fusiondirectory/html/sinaps.php(79): sinapsDiffusionHandlerJob->h in <b>/usr/share/fusiondirectory/include/simpleplugin/attributes/class_SetAttribute.inc</b> on line <b>352</b><br />
***** End of server response *****
```
**Reproduces how often:**
100%
### Additional Information
as attachement xml file and dry-run file
parent structure exist !
[DAFA-G-GEST.DRY-RUN](/uploads/36deb20606ff0bd506235e3a2ba212cd/DAFA-G-GEST.DRY-RUN)
[DAFA-G-GEST.xml](/uploads/4fc605844986f877da9918e0466300aa/DAFA-G-GEST.xml)FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5941Error when identity is spread from SINAPS "Cannot delete non-existing user {...2019-06-28T20:53:43ZagallavardinError when identity is spread from SINAPS "Cannot delete non-existing user {LDAPUUID}"### Description
strange error during "diffusion" : spread an identity from SINAPS to FD
on SINAPS side : identity didn't have FD cross-reference
on FD side : account exist (tested with a prefilled LDAPUUID and without a pre filled LDAP...### Description
strange error during "diffusion" : spread an identity from SINAPS to FD
on SINAPS side : identity didn't have FD cross-reference
on FD side : account exist (tested with a prefilled LDAPUUID and without a pre filled LDAPUUID)
### Distribution Name and Version
Debian 9.8
### FusionDirectory Version
1.3 from integration
### Plugin with the defect
fusiondirectory-sinaps 1.3.1 from gz from sources
plugins install with fusiondirectory-setup --plugins
### PHP version used
php 7
### Origin of php packages
from oficiel Deb repos
### Steps to Reproduce
1. spread to FusionDirectory an identity with no cross reference, on FD there a corresponding user ( same sn and givenname) with a pre filled LDAPUUID
2. check the xml-acquittement
**Expected behavior:**
on current installation ( 1.3 ) we have an error like `"The entry 'uid=john.doe,ou=people,ou=site,dc=company,dc=fr' already use this 'Login' attribute!`[b8048447-f719-4c2d-bb9e-b94dffcb9eba.xml](/uploads/b11420c4fffef94d3eaba202edfa62ea/b8048447-f719-4c2d-bb9e-b94dffcb9eba.xml)
[3f646d29-e346-4095-a6b2-ef61d93b6619-acquittement.xml](/uploads/92866486808be5c59da1a705e8e2693e/3f646d29-e346-4095-a6b2-ef61d93b6619-acquittement.xml)
[b8048447-f719-4c2d-bb9e-b94dffcb9eba-acquittement.xml](/uploads/8123fbbf55bdd6ee2cd366849a59dd7d/b8048447-f719-4c2d-bb9e-b94dffcb9eba-acquittement.xml)
[3f646d29-e346-4095-a6b2-ef61d93b6619.xml](/uploads/66049cd6ef10fec811c4563b34f77ff2/3f646d29-e346-4095-a6b2-ef61d93b6619.xml)
**Actual behavior:**
we have the following error :
`Erreur Fonctionnelle - Code réponse 200 : Données pour la transaction 4e5a42f3-7d5e-4146-aad0-87b5f8bb6096 non intégrées - Cannot delete non-existing user {LDAPUUID}e2dda2de-c842-4e8f-8163-d0c174fd4ddc`
If diffusion is done again the LDAPUUID in error message change .
those LDAPUUID didn't exist inside LDAP tree
**Reproduces how often:**
100 % with the same userFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5918SINAPS : acquisition couldn't be sent because primary affectation isn't set2019-06-28T20:53:43ZagallavardinSINAPS : acquisition couldn't be sent because primary affectation isn't set### Description
After creating an account, FD could send contact method juste after
### Distribution Name and Version
Debian Stretch
### FusionDirectory Version
fusiondirectory 1.3-2~jenkinsbuild96
### Plugin wit...### Description
After creating an account, FD could send contact method juste after
### Distribution Name and Version
Debian Stretch
### FusionDirectory Version
fusiondirectory 1.3-2~jenkinsbuild96
### Plugin with the defect
ii fusiondirectory-plugin-sinaps 1.3-2~jenkinsbuild96
### PHP version used
php7
### Origin of php packages
from debian repos
### Steps to Reproduce
1. from sinaps, send a new user
2. check if supannEntiteAffectationPrincipale is filled
**Expected behavior:**
both supannEntiteAffectationPrincipale field and supannEntiteAffectation should be filled
**Actual behavior:**
only supannEntiteAffectation is filled
**Reproduces how often:**
It seems that that is not always the case. I'm note sure that is in 100%
### Additional Information
if no affectation are filled, xml sent to SINAPS in order to send contact method has no success to be integrated.FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5948description of a user should'nt be updated from SINAPS2019-06-28T20:53:42Zagallavardindescription of a user should'nt be updated from SINAPS### Description
Description is updated from sinaps, Finally it isn't a good idea
### Distribution Name and Version
debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
sinaps
### PHP version used
7
### Origin of php pa...### Description
Description is updated from sinaps, Finally it isn't a good idea
### Distribution Name and Version
debian
### FusionDirectory Version
1.3.1
### Plugin with the defect
sinaps
### PHP version used
7
### Origin of php packages
debian
### Steps to Reproduce
1. set a accoutn on Fd with a description
2. Sync the Id( with a blank description from sinaps to FD
**Expected behavior:**
description shouldn't be synced
**Actual behavior:**
description is synced
**Reproduces how often:**
100 %
### Additional Information
remove line 213 inside include/class_sinapsRequest.inc should do the trickFusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5913Avoid mass acquistion when editing group gidNumber2019-06-28T20:53:42ZagallavardinAvoid mass acquistion when editing group gidNumber### Requirements
## Descriptive title for this enhancement
### Actual behavior
When a posix group is deleted or modified ( like modified the gidNumber or name ), Fd check consistency on all people which user the posixAccount feature.
...### Requirements
## Descriptive title for this enhancement
### Actual behavior
When a posix group is deleted or modified ( like modified the gidNumber or name ), Fd check consistency on all people which user the posixAccount feature.
By checking consistency of all account and if SINAPS is enabled all account is scanned and corresponding acquisition is sent
I see in log ldap request to get all attribute sent to sinaps
```
Jan 25 10:15:28 mc-pas-test slapd[698]: conn=17763 op=21987 SRCH attr=supannRefId supannEntiteAffectationPrincipale telephoneNumber facsimileTelephoneNumber mail mobi
le dn
```
for one modification I see 382 request
```
root@mc-pas-test:/var/cache/fusiondirectory/tmp# grep " SRCH attr=supannRefId supannEntiteAffectationPrincipale" /var/log/syslog |grep 17763 |wc -l
382
```
which is corresponding to posixuser concerned by the modified group
### Expected behavior
Acquisition is sent only when field specified in fdSinapsAcquisitionContactMethodMap are modified
### Step by step description of new behaviour
1. modify/delete a group
2. as this change didn't concern to sinaps information no acquisition should be launched
### Benefits
group modification more quick
### Possible Drawbacks
code complexity
### additional information
It seems that modification launch other actions like mailbox check ( partage for example)FusionDirectory 1.3.1Côme ChillietCôme Chilliethttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5957creating icons for the sinaps plugin2019-06-28T20:53:42Zbmortiercreating icons for the sinaps plugin## Descriptive title for this enhancement
creating icons for the sinaps plugin
### Actual behavior
the sinaps plugin is missing an icon in 16px and 48px
### Expected behavior
to be able to show the sinaps icons in the filter list
#...## Descriptive title for this enhancement
creating icons for the sinaps plugin
### Actual behavior
the sinaps plugin is missing an icon in 16px and 48px
### Expected behavior
to be able to show the sinaps icons in the filter list
### Benefits
Be able to select user having sinaps activated in the list or filter
### Possible Drawbacks
noneFusionDirectory 1.3.1animtimanimtimhttps://gitlab.fusiondirectory.org/fusiondirectory/fd-plugins/-/issues/5910plugins sinaps : in case of mass transfer from sinaps to FD , disable post ac...2019-02-13T16:20:14Zagallavardinplugins sinaps : in case of mass transfer from sinaps to FD , disable post action or web service actions### Requirements
## Descriptive title for this enhancement
when we push a lot of diffusion to FD, FD try to apply a template.
### Actual behavior
If the template use an external actions ( like mailbox check on remote mail server), th...### Requirements
## Descriptive title for this enhancement
when we push a lot of diffusion to FD, FD try to apply a template.
### Actual behavior
If the template use an external actions ( like mailbox check on remote mail server), this diffusion could take a long time.
### Expected behavior
Is there a way to a add a switch which disable all external actions ( like mailbox checking ) for some purpose like :
* mass import
* testing with create external resources like mailbox
### Step by step description of new behavior
1. spread all identity to FD
2. FD apply all template and could take a loooong time due to external request
### Benefits
testing and mass import more efficient
### Possible Drawbacks
complexity ?Côme ChillietCôme Chilliet