group membership checking in argonaut-fuse should be reworked
Hello,
the group membership in argonaut-fuse is strange because it depends on certain value only
Collect all vital data
Use first server defined in ldap
my $new_ldap = defined($entry->get_value( 'gotoLdapServer', asref => 1 ))?@{ $entry->get_value( 'gotoLdapServer', asref => 1 ) }[0]:undef; $ldap_srv = $new_ldap if( defined $new_ldap );
$kernel = $entry->get_value( 'gotoBootKernel' ); $cmdline = $entry->get_value( 'gotoKernelParameters' );
If any of these values isn't provided by the client check group membership
if ((! defined $kernel) || ("" eq $kernel) || (! defined $cmdline) || ("" eq $cmdline) || (! defined $ldap_srv) || ("" eq $ldap_srv)) { $log->info("$filename - Information for PXE creation is missing\n"); $log->info("$filename - Checking group membership...\n");
we should look at what is really needed and whats not
Cheers
(from redmine: issue id 2985, created on 2014-02-07, closed on 2014-02-07)
- Changesets:
- Revision d5257bd0 by Côme Chilliet on 2014-02-07T12:27:47.000Z:
Fixes #2985 Using Common argonaut_get_settings in fuse/fai
- Revision ee991b8f by Côme Chilliet on 2014-02-07T12:38:04.000Z:
Fixes #2985 missing \
- Revision b9bff027 by Côme Chilliet on 2014-02-07T15:06:39.000Z:
Fixes #2985 Missing "my"
- Revision 43b6f783 by Côme Chilliet on 2014-02-07T15:41:35.000Z:
Fixes #2985 Using double quotes instead of simple
- Revision c51ec731 by Côme Chilliet on 2014-02-07T15:52:21.000Z:
Fixes #2985 remove was called on wrong var